You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Alexander Sinyushkin <Al...@svnkit.com> on 2008/06/02 15:44:54 UTC

[PATCH] python/cmdline (was: [PATCH] 1.5.x branch: python/cmdline)

Hello once again,

I'm reposting this patch in hope that someone will take a look at it.

[[[
Add a number of SVNKit related fixes to main.py

Make use_jsvn a global variable which if True allows
SVN_CURRENT_TEST SVNKit specific environment variable
to be set to the current running test.

svndumpfilter_binary should point to a jsvndumpfilter
binary if --use-jsvn is specified.

* subversion/tests/cmdline/svntest/main.py
   (use_jsvn): make use_jsvn a global variable that reflects
               whether --use-jsvn is passed or not; do not
               set use_jsvn to False at the end of if use_jsvn:
               clause
   (copy_repos): close dump_in just after the first call to
                 open_pipe()
   (run): if use_jsvn is True set SVN_CURRENT_TEST environment
          variable to the current test being run
   (run_tests): make svndumpfilter_binary point to jsvndumpfilter
                binary if use_jsvn is True
]]]

----
Alexander Sinyushkin,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library!

Re: [PATCH] python/cmdline

Posted by Alexander Sinyushkin <Al...@svnkit.com>.
Thanks, Karl!
----
Alexander Sinyushkin,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library!

Karl Fogel wrote:
> Alexander Sinyushkin <Al...@svnkit.com> writes:
>> Hello once again,
>>
>> I'm reposting this patch in hope that someone will take a look at it.
> 
> r31560
> 
> (I think the "close dump_in" change could have been a separate patch, as
> it is logically independent of the other changes, but I didn't bother.
> Just try to keep an eye out for independent things next time.)
> 
> -Karl
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
> 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] python/cmdline

Posted by Karl Fogel <kf...@red-bean.com>.
Alexander Sinyushkin <Al...@svnkit.com> writes:
> Hello once again,
>
> I'm reposting this patch in hope that someone will take a look at it.

r31560

(I think the "close dump_in" change could have been a separate patch, as
it is logically independent of the other changes, but I didn't bother.
Just try to keep an eye out for independent things next time.)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org