You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2024/10/21 12:33:58 UTC
[PR] [chore](status) Static member accessed through instance [doris]
Mryange opened a new pull request, #42213:
URL: https://github.com/apache/doris/pull/42213
## Proposed changes
The capitalized OK in status constructs an "ok" status.
Since we allow status to be converted to bool, these checks are redundant.
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2426613317
TeamCity be ut coverage result:
Function Coverage: 37.46% (9699/25891)
Line Coverage: 28.70% (80494/280472)
Region Coverage: 28.14% (41651/147990)
Branch Coverage: 24.72% (21171/85638)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e818c4d31dc0a1df0bf48a9a2b730f592e931675_e818c4d31dc0a1df0bf48a9a2b730f592e931675/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2427036174
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2426681041
<details>
<summary>TPC-DS: <b>Total hot run time: 193208 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e818c4d31dc0a1df0bf48a9a2b730f592e931675, data reload: false
query1 885 397 386 386
query2 6249 2143 2077 2077
query3 8675 189 202 189
query4 34562 23762 23627 23627
query5 3437 479 473 473
query6 268 166 164 164
query7 4182 297 287 287
query8 286 223 220 220
query9 9772 2735 2737 2735
query10 454 285 282 282
query11 17880 15256 15297 15256
query12 155 100 101 100
query13 1562 428 413 413
query14 9609 7572 7402 7402
query15 245 179 183 179
query16 7976 511 475 475
query17 1646 610 618 610
query18 2158 307 317 307
query19 369 168 158 158
query20 123 115 124 115
query21 220 114 108 108
query22 4886 4577 4670 4577
query23 34832 34089 34148 34089
query24 11067 2724 2735 2724
query25 638 416 409 409
query26 1286 158 170 158
query27 2583 290 290 290
query28 7828 2418 2418 2418
query29 859 428 423 423
query30 260 154 160 154
query31 1073 814 805 805
query32 95 60 59 59
query33 763 305 302 302
query34 935 535 514 514
query35 908 776 735 735
query36 1098 943 961 943
query37 161 92 88 88
query38 4017 4005 3957 3957
query39 1476 1437 1412 1412
query40 262 101 102 101
query41 49 49 48 48
query42 128 104 106 104
query43 555 521 512 512
query44 1241 802 819 802
query45 199 163 167 163
query46 1151 721 714 714
query47 1953 1825 1868 1825
query48 420 330 333 330
query49 926 429 444 429
query50 819 402 413 402
query51 7160 7010 7051 7010
query52 105 89 94 89
query53 265 182 179 179
query54 1142 441 446 441
query55 82 77 81 77
query56 305 262 288 262
query57 1353 1162 1137 1137
query58 233 231 231 231
query59 3138 3149 3341 3149
query60 292 270 269 269
query61 109 101 101 101
query62 878 659 685 659
query63 233 191 186 186
query64 4647 636 607 607
query65 3300 3233 3222 3222
query66 1055 300 299 299
query67 15955 15869 15675 15675
query68 4422 557 574 557
query69 478 296 286 286
query70 1169 1133 1143 1133
query71 376 281 282 281
query72 7104 3960 4017 3960
query73 777 362 365 362
query74 10280 9077 9228 9077
query75 3440 2757 2686 2686
query76 2690 886 909 886
query77 662 324 328 324
query78 10443 9749 9704 9704
query79 1570 588 603 588
query80 2270 437 463 437
query81 580 238 235 235
query82 725 138 143 138
query83 298 142 136 136
query84 274 72 75 72
query85 1553 296 284 284
query86 422 305 278 278
query87 4508 4314 4324 4314
query88 3347 2219 2201 2201
query89 416 298 295 295
query90 2186 192 188 188
query91 147 100 95 95
query92 62 51 57 51
query93 1109 540 550 540
query94 1214 294 305 294
query95 361 250 253 250
query96 621 281 288 281
query97 3314 3124 3187 3124
query98 222 204 196 196
query99 1616 1323 1312 1312
Total cold run time: 302089 ms
Total hot run time: 193208 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2428435529
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 merged PR #42213:
URL: https://github.com/apache/doris/pull/42213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2426545063
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2426555819
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2426545333
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2428435589
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2426648632
<details>
<summary>TPC-H: <b>Total hot run time: 41335 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e818c4d31dc0a1df0bf48a9a2b730f592e931675, data reload: false
------ Round 1 ----------------------------------
q1 17578 7398 7584 7398
q2 2033 282 283 282
q3 11779 1072 1227 1072
q4 10581 820 824 820
q5 7757 3117 3038 3038
q6 240 155 146 146
q7 1020 641 610 610
q8 9366 1991 1926 1926
q9 6672 6468 6430 6430
q10 7044 2393 2496 2393
q11 439 244 237 237
q12 408 221 217 217
q13 17759 2995 3011 2995
q14 243 204 213 204
q15 563 526 529 526
q16 634 584 600 584
q17 980 518 556 518
q18 7239 6694 6781 6694
q19 1341 921 922 921
q20 482 181 182 181
q21 4010 3173 3128 3128
q22 1107 1015 1021 1015
Total cold run time: 109275 ms
Total hot run time: 41335 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7301 7237 7237 7237
q2 324 235 237 235
q3 3014 2927 2889 2889
q4 2115 1817 1849 1817
q5 5769 5749 5770 5749
q6 238 147 153 147
q7 2222 1841 1798 1798
q8 3377 3521 3407 3407
q9 8985 8969 8965 8965
q10 3592 3539 3574 3539
q11 583 491 494 491
q12 819 644 672 644
q13 10848 3199 3204 3199
q14 306 277 273 273
q15 584 524 526 524
q16 707 650 643 643
q17 1855 1600 1606 1600
q18 8272 7929 7726 7726
q19 1691 1513 1476 1476
q20 2107 1888 1870 1870
q21 5645 5428 5359 5359
q22 1162 1033 1052 1033
Total cold run time: 71516 ms
Total hot run time: 60621 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](status) Static member accessed through instance [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42213:
URL: https://github.com/apache/doris/pull/42213#issuecomment-2426696413
<details>
<summary>ClickBench: <b>Total hot run time: 33.11 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e818c4d31dc0a1df0bf48a9a2b730f592e931675, data reload: false
query1 0.04 0.04 0.03
query2 0.06 0.03 0.03
query3 0.23 0.06 0.06
query4 1.64 0.10 0.10
query5 0.53 0.50 0.51
query6 1.13 0.73 0.73
query7 0.02 0.01 0.01
query8 0.04 0.03 0.03
query9 0.55 0.50 0.51
query10 0.54 0.55 0.55
query11 0.13 0.10 0.10
query12 0.14 0.11 0.10
query13 0.61 0.60 0.60
query14 2.73 2.86 2.73
query15 0.90 0.82 0.83
query16 0.38 0.38 0.36
query17 1.04 1.09 1.06
query18 0.20 0.20 0.20
query19 1.93 1.80 2.06
query20 0.01 0.01 0.01
query21 15.37 0.58 0.60
query22 2.59 1.93 2.66
query23 17.06 0.87 0.87
query24 2.76 1.55 1.20
query25 0.17 0.25 0.15
query26 0.60 0.14 0.14
query27 0.04 0.04 0.04
query28 10.16 1.09 1.07
query29 12.58 3.22 3.19
query30 0.25 0.06 0.06
query31 2.86 0.38 0.38
query32 3.28 0.46 0.45
query33 2.97 3.01 3.04
query34 17.13 4.47 4.50
query35 4.53 4.50 4.47
query36 0.69 0.49 0.48
query37 0.08 0.06 0.06
query38 0.05 0.03 0.04
query39 0.03 0.02 0.02
query40 0.16 0.13 0.12
query41 0.08 0.02 0.02
query42 0.04 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 106.37 s
Total hot run time: 33.11 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org