You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/28 22:25:44 UTC

[GitHub] szhem commented on issue #23438: [SPARK-26525][SHUFFLE]Fast release ShuffleBlockFetcherIterator on completion of the iteration

szhem commented on issue #23438: [SPARK-26525][SHUFFLE]Fast release ShuffleBlockFetcherIterator on completion of the iteration
URL: https://github.com/apache/spark/pull/23438#issuecomment-458326798
 
 
   @liupc I believe that this PR is very similar to this already closed one - #23083.
   At first it added `TaskContext.removeTaskCompletionListener` too, but according to the comments of @advancedxy and @cloud-fan [here](https://github.com/apache/spark/pull/23083/files#r235955118) and [here](https://github.com/apache/spark/pull/23083#issuecomment-441229846) it would be better not to introduce an additional public API.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org