[jira] [Commented] (KAFKA-6579) Consolidate window store and session store unit tests into a single class

["Stanislav Pak (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254130#comment-17254130 ] 

Stanislav Pak commented on KAFKA-6579:
--------------------------------------

This looks non-trivial based on previous attempts, but I will give it a shot. Try lock [~guozhang]..

> Consolidate window store and session store unit tests into a single class
> -------------------------------------------------------------------------
>
>                 Key: KAFKA-6579
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6579
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Priority: Major
>              Labels: newbie, unit-test
>
> For key value store, we have a {{AbstractKeyValueStoreTest}} that is shared among all its implementations; however for window and session stores, each class has its own independent unit test classes that do not share the test coverage. In fact, many of these test classes share the same unit test functions (e.g. {{RocksDBWindowStoreTest}}, {{CompositeReadOnlyWindowStoreTest}} and {{CachingWindowStoreTest}}).
> It is better to use the same pattern as for key value stores to consolidate these test functions into a shared base class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)