You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by edewit <gi...@git.apache.org> on 2014/09/23 08:58:06 UTC
[GitHub] cordova-lib pull request: Project plugins
GitHub user edewit opened a pull request:
https://github.com/apache/cordova-lib/pull/90
Project plugins
creates projects for each added plugin and adds them to the workspace.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/edewit/cordova-lib project-plugins
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit 001fd62a121d6ff65e3c3af80b0153308c1675e8
Author: Erik Jan de Wit <er...@gmail.com>
Date: 2014-09-22T14:03:17Z
generates a project for each installed plugin
commit 53bdd059577006fd7a9e7ba28257272a6487b7ac
Author: Erik Jan de Wit <er...@gmail.com>
Date: 2014-09-23T05:59:11Z
add plugin project to workspace
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Project plugins
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/90#discussion_r18538787
--- Diff: cordova-lib/package.json ---
@@ -36,7 +36,8 @@
"underscore": "1.4.4",
"xcode": "0.6.6",
"cordova-js": "3.x.x",
- "unorm": ">=1.3"
+ "unorm": ">=1.3",
+ "libxmljs": "~0.11.1"
--- End diff --
cordova-lib already depends on elementtree for xml. Is this new library really necessary (could elementtree be used instead)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Project plugins
Posted by edewit <gi...@git.apache.org>.
Github user edewit commented on the pull request:
https://github.com/apache/cordova-lib/pull/90#issuecomment-56484587
builds on top of cordova-ios/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Project plugins
Posted by shortstuffsushi <gi...@git.apache.org>.
Github user shortstuffsushi commented on the pull request:
https://github.com/apache/cordova-lib/pull/90#issuecomment-59988944
Can someone who knows the build explain what has failed here? It's not really clear from the AppVeyor output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Project plugins
Posted by edewit <gi...@git.apache.org>.
Github user edewit closed the pull request at:
https://github.com/apache/cordova-lib/pull/90
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Project plugins
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/pull/90#issuecomment-59990633
I can't say precisely, but, here's what I did:
```sh
$ git fetch --all
$ git branch -f master apache/master
$ cd cordova-lib/
```
Updates.
Try master:
```sh
$ git checkout master
...
Switched to branch 'master'
Your branch is up-to-date with 'apache/master'.
$ npm run jasmine && npm run jshint
> cordova-lib@4.0.1-dev jasmine ~/Cordova/cordova-lib/cordova-lib
> jasmine-node --captureExceptions --color spec-plugman spec-cordova
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Finished in 14.781 seconds
726 tests, 1027 assertions, 0 failures, 0 skipped
> cordova-lib@4.0.1-dev jshint ~/Cordova/cordova-lib/cordova-lib
> node node_modules/jshint/bin/jshint src
```
Now, try your branch:
```sh
$ git checkout origin/pr/90
$ npm run jasmine && npm run jshint
> cordova-lib@0.21.8-dev jasmine ~/Cordova/cordova-lib/cordova-lib
> jasmine-node --captureExceptions --color spec-plugman spec-cordova
....................................................................................................
....................................................................................................
....................................................................................................
....................................................................................................
.........................................................................................FFFFFFFFFFF
FFFFFFFFFFFFF..FFFFFFF..............................................................................
...........FF..............................................................................
```
It's pretty verbose locally explaining each of the errors...
I'm not including them here because I don't think it's necessary. You should be able to do the same as it/I did and get the same omitted.
```
Finished in 9.267 seconds
691 tests, 952 assertions, 33 failures, 0 skipped
npm ERR! weird error 1
npm ERR! not ok code 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org