You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "KiteSoar (via GitHub)" <gi...@apache.org> on 2026/01/18 15:43:10 UTC

[PR] feat: Support bloom filter in Lance writer [hudi]

KiteSoar opened a new pull request, #17939:
URL: https://github.com/apache/hudi/pull/17939

   ### Describe the issue this Pull Request addresses
   
   Closes #17664
   
   
   ### Summary and Changelog
   
   Implemented Bloom Filter support for the Lance file format writer.
   
   <!-- Short, plain-English summary of what users gain or what changed in behavior.
        Followed by a detailed log of all the changes. Highlight if any code was copied. -->
   
   ### Impact
   Enables Bloom Filter index support for Lance files, allowing for efficient record key lookups and data skipping.
   
   <!-- Describe any public API or user-facing feature change or any performance impact. -->
   
   ### Risk Level
   
   Low
   
   <!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
        If medium or high, explain what verification was done to mitigate the risks. -->
   
   ### Documentation Update
   
   None
   
   <!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
   
   - The config description must be updated if new configs are added or the default value of the configs are changed.
   - Any new feature or user-facing change requires updating the Hudi website. Please follow the 
     [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035724557

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213",
       "triggerID" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12522",
       "triggerID" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3598ac9582779208efab962ca8b50bb6ed04539c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12561",
       "triggerID" : "3598ac9582779208efab962ca8b50bb6ed04539c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 956e8bc6d3e0f9010f61cd0316527edc227aa318 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12522) 
   * 3598ac9582779208efab962ca8b50bb6ed04539c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12561) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035876732

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 43.35%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 10 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-scala-tests|6|3|
   >|spark-java-tests|9|2|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   43.35%   -13.97%     
   + Complexity    18631    13880     -4751     
   =============================================
     Files          1955     1956        +1     
     Lines        106932   107014       +82     
     Branches      13231    13242       +11     
   =============================================
   - Hits          61291    46398    -14893     
   - Misses        39854    55272    +15418     
   + Partials       5787     5344      -443     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.52% <21.21%> (-13.97%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <21.21%> (-12.50%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `67.10% <ø> (-8.22%)` | :arrow_down: |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [792 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029561227

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213",
       "triggerID" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f1149b5f90dd7e8030ce9ff5c4d898255cccb48e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213) 
   * 956e8bc6d3e0f9010f61cd0316527edc227aa318 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035966790

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `84.84848%` with `5 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 57.27%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 86.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   57.27%   -0.04%     
   - Complexity    18631    18647      +16     
   ============================================
     Files          1955     1956       +1     
     Lines        106932   107014      +82     
     Branches      13231    13242      +11     
   ============================================
   + Hits          61291    61297       +6     
   - Misses        39854    39918      +64     
   - Partials       5787     5799      +12     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.39% <84.84%> (-0.10%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <21.21%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `74.75% <ø> (-0.58%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `90.00% <86.66%> (-5.00%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `64.78% <62.50%> (-2.40%)` | :arrow_down: |
   
   ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun closed pull request #17939: feat: Support bloom filter in Lance writer
URL: https://github.com/apache/hudi/pull/17939


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029574068

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213",
       "triggerID" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12522",
       "triggerID" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f1149b5f90dd7e8030ce9ff5c4d898255cccb48e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213) 
   * 956e8bc6d3e0f9010f61cd0316527edc227aa318 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12522) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "KiteSoar (via GitHub)" <gi...@apache.org>.
KiteSoar commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4015040861

   > hi @KiteSoar ! are you still here? could you rebase your branch and resolve conflicts?
   
   
   
   > hi @KiteSoar ! are you still here? could you rebase your branch and resolve conflicts?
   
   Sure! I'll take care of it ASAP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-3765425014

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-3766546311

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 988bc9f20c46e5bff3e6e30bafc643b43d9076cd Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-3766360156

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188) 
   * 988bc9f20c46e5bff3e6e30bafc643b43d9076cd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-3765427923

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035911018

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `72.72727%` with `9 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.46%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 60.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   55.46%   -1.86%     
   + Complexity    18631    17993     -638     
   ============================================
     Files          1955     1956       +1     
     Lines        106932   107014      +82     
     Branches      13231    13242      +11     
   ============================================
   - Hits          61291    59355    -1936     
   - Misses        39854    41783    +1929     
   - Partials       5787     5876      +89     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.38% <72.72%> (-4.12%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <21.21%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `74.08% <ø> (-1.24%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `57.74% <62.50%> (-9.45%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `78.00% <60.00%> (-17.00%)` | :arrow_down: |
   
   ... and [258 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035910612

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `72.72727%` with `9 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.46%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 60.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   55.46%   -1.86%     
   + Complexity    18631    17993     -638     
   ============================================
     Files          1955     1956       +1     
     Lines        106932   107014      +82     
     Branches      13231    13242      +11     
   ============================================
   - Hits          61291    59355    -1936     
   - Misses        39854    41783    +1929     
   - Partials       5787     5876      +89     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.38% <72.72%> (-4.12%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <21.21%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `74.08% <ø> (-1.24%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `57.74% <62.50%> (-9.45%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `78.00% <60.00%> (-17.00%)` | :arrow_down: |
   
   ... and [258 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-3768588075

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 988bc9f20c46e5bff3e6e30bafc643b43d9076cd Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195) 
   * f1149b5f90dd7e8030ce9ff5c4d898255cccb48e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029975964

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `85.29412%` with `5 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 57.31%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 91.30% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   57.31%   -0.01%     
   - Complexity    18631    18639       +8     
   ============================================
     Files          1955     1955              
     Lines        106932   106960      +28     
     Branches      13231    13233       +2     
   ============================================
   + Hits          61291    61303      +12     
   - Misses        39854    39860       +6     
   - Partials       5787     5797      +10     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.48% <85.29%> (-0.01%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `91.52% <91.30%> (-3.48%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `64.78% <62.50%> (-2.40%)` | :arrow_down: |
   
   ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029851599

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `26.47059%` with `25 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.27%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 26.08% | [16 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 37.50% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   55.27%   -2.05%     
   + Complexity    18631    17929     -702     
   ============================================
     Files          1955     1955              
     Lines        106932   106960      +28     
     Branches      13231    13233       +2     
   ============================================
   - Hits          61291    59119    -2172     
   - Misses        39854    41986    +2132     
   - Partials       5787     5855      +68     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.18% <26.47%> (-4.32%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <0.00%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `54.92% <37.50%> (-12.26%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `61.01% <26.08%> (-33.99%)` | :arrow_down: |
   
   ... and [275 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4036015040

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213",
       "triggerID" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12522",
       "triggerID" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3598ac9582779208efab962ca8b50bb6ed04539c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12561",
       "triggerID" : "3598ac9582779208efab962ca8b50bb6ed04539c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3598ac9582779208efab962ca8b50bb6ed04539c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12561) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4010490867

   hi @KiteSoar ! are you still here?
   could you rebase your branch and resolve conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-3768981169

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213",
       "triggerID" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f1149b5f90dd7e8030ce9ff5c4d898255cccb48e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-3765502437

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035894733

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 51.71%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 8 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-scala-tests|6|4|
   >|spark-java-tests|9|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   51.71%   -5.60%     
   + Complexity    18631    16633    -1998     
   ============================================
     Files          1955     1956       +1     
     Lines        106932   107014      +82     
     Branches      13231    13242      +11     
   ============================================
   - Hits          61291    55347    -5944     
   - Misses        39854    45670    +5816     
   - Partials       5787     5997     +210     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <21.21%> (-14.32%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.33% <21.21%> (-0.26%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `67.77% <ø> (-7.56%)` | :arrow_down: |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [536 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035986258

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `84.84848%` with `5 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 57.29%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 86.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   57.29%   -0.02%     
   - Complexity    18631    18652      +21     
   ============================================
     Files          1955     1956       +1     
     Lines        106932   107014      +82     
     Branches      13231    13242      +11     
   ============================================
   + Hits          61291    61319      +28     
   - Misses        39854    39900      +46     
   - Partials       5787     5795       +8     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.47% <84.84%> (-0.02%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <21.21%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `74.75% <ø> (-0.58%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `90.00% <86.66%> (-5.00%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `64.78% <62.50%> (-2.40%)` | :arrow_down: |
   
   ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035978023

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `84.84848%` with `5 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 57.28%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 86.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   57.28%   -0.04%     
   - Complexity    18631    18648      +17     
   ============================================
     Files          1955     1956       +1     
     Lines        106932   107014      +82     
     Branches      13231    13242      +11     
   ============================================
   + Hits          61291    61298       +7     
   - Misses        39854    39918      +64     
   - Partials       5787     5798      +11     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.42% <84.84%> (-0.07%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <21.21%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `74.75% <ø> (-0.58%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `90.00% <86.66%> (-5.00%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `64.78% <62.50%> (-2.40%)` | :arrow_down: |
   
   ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035763231

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `8 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.21%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-scala-tests|6|0|
   >|spark-java-tests|9|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   45.21%   -12.11%     
   + Complexity    18631     8416    -10215     
   =============================================
     Files          1955     1186      -769     
     Lines        106932    60870    -46062     
     Branches      13231     6494     -6737     
   =============================================
   - Hits          61291    27521    -33770     
   + Misses        39854    30359     -9495     
   + Partials       5787     2990     -2797     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   
   ... and [1387 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029652635

   [hudi-lance-bloom-refactoring.patch](https://github.com/user-attachments/files/25864306/hudi-lance-bloom-refactoring.patch)
   @KiteSoar add me as a collaborator to your hudi repo or apply this patch and push please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029943439

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `85.29412%` with `5 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 57.30%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 91.30% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   57.30%   -0.02%     
   - Complexity    18631    18636       +5     
   ============================================
     Files          1955     1955              
     Lines        106932   106960      +28     
     Branches      13231    13233       +2     
   ============================================
   + Hits          61291    61294       +3     
   - Misses        39854    39866      +12     
   - Partials       5787     5800      +13     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.41% <85.29%> (-0.08%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `91.52% <91.30%> (-3.48%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `64.78% <62.50%> (-2.40%)` | :arrow_down: |
   
   ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035855141

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 40.37%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 14 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-scala-tests|6|1|
   >|spark-java-tests|9|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   40.37%   -16.95%     
   + Complexity    18631    12298     -6333     
   =============================================
     Files          1955     1922       -33     
     Lines        106932   102294     -4638     
     Branches      13231    12153     -1078     
   =============================================
   - Hits          61291    41301    -19990     
   - Misses        39854    56132    +16278     
   + Partials       5787     4861      -926     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.54% <21.21%> (-12.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `47.84% <ø> (-27.49%)` | :arrow_down: |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [894 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035907224

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 51.87%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 6 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-java-tests|9|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   51.87%   -5.45%     
   + Complexity    18631    16679    -1952     
   ============================================
     Files          1955     1956       +1     
     Lines        106932   107014      +82     
     Branches      13231    13242      +11     
   ============================================
   - Hits          61291    55509    -5782     
   - Misses        39854    45528    +5674     
   - Partials       5787     5977     +190     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <21.21%> (-14.32%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <21.21%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `67.77% <ø> (-7.56%)` | :arrow_down: |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [506 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029618401

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `8 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.21%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (956e8bc). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (956e8bc) |
   >|------|------|------|
   >|spark-scala-tests|6|0|
   >|spark-java-tests|9|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   45.21%   -12.11%     
   + Complexity    18631     8416    -10215     
   =============================================
     Files          1955     1186      -769     
     Lines        106932    60863    -46069     
     Branches      13231     6494     -6737     
   =============================================
   - Hits          61291    27520    -33771     
   + Misses        39854    30354     -9500     
   + Partials       5787     2989     -2798     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   
   ... and [1386 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029791515

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `34 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 43.38%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (956e8bc). Click for more details.
   > 
   > <details><summary>HEAD has 10 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (956e8bc) |
   >|------|------|------|
   >|spark-scala-tests|6|3|
   >|spark-java-tests|9|2|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   43.38%   -13.94%     
   + Complexity    18631    13877     -4754     
   =============================================
     Files          1955     1955               
     Lines        106932   106960       +28     
     Branches      13231    13233        +2     
   =============================================
   - Hits          61291    46404    -14887     
   - Misses        39854    55222    +15368     
   + Partials       5787     5334      -453     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.62% <0.00%> (-13.87%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <0.00%> (-12.49%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [783 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029766508

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `34 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 39.62%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (956e8bc). Click for more details.
   > 
   > <details><summary>HEAD has 12 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (956e8bc) |
   >|------|------|------|
   >|spark-scala-tests|6|3|
   >|spark-java-tests|9|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   39.62%   -17.70%     
   + Complexity    18631    12625     -6006     
   =============================================
     Files          1955     1955               
     Lines        106932   106960       +28     
     Branches      13231    13233        +2     
   =============================================
   - Hits          61291    42385    -18906     
   - Misses        39854    59480    +19626     
   + Partials       5787     5095      -692     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <0.00%> (-12.49%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [857 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029801618

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `34 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 43.42%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (956e8bc). Click for more details.
   > 
   > <details><summary>HEAD has 9 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (956e8bc) |
   >|------|------|------|
   >|spark-scala-tests|6|3|
   >|spark-java-tests|9|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   43.42%   -13.90%     
   + Complexity    18631    13887     -4744     
   =============================================
     Files          1955     1955               
     Lines        106932   106960       +28     
     Branches      13231    13233        +2     
   =============================================
   - Hits          61291    46444    -14847     
   - Misses        39854    55184    +15330     
   + Partials       5787     5332      -455     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <0.00%> (-14.31%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <0.00%> (-12.49%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [783 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029846716

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `34 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 51.84%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (956e8bc). Click for more details.
   > 
   > <details><summary>HEAD has 7 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (956e8bc) |
   >|------|------|------|
   >|spark-scala-tests|6|5|
   >|spark-java-tests|9|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   51.84%   -5.47%     
   + Complexity    18631    16656    -1975     
   ============================================
     Files          1955     1955              
     Lines        106932   106960      +28     
     Branches      13231    13233       +2     
   ============================================
   - Hits          61291    55457    -5834     
   - Misses        39854    45529    +5675     
   - Partials       5787     5974     +187     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <0.00%> (-14.31%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <0.00%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [505 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029968932

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `85.29412%` with `5 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 57.30%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 91.30% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   57.30%   -0.02%     
   - Complexity    18631    18638       +7     
   ============================================
     Files          1955     1955              
     Lines        106932   106960      +28     
     Branches      13231    13233       +2     
   ============================================
   + Hits          61291    61296       +5     
   - Misses        39854    39865      +11     
   - Partials       5787     5799      +12     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.44% <85.29%> (-0.05%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `91.52% <91.30%> (-3.48%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `64.78% <62.50%> (-2.40%)` | :arrow_down: |
   
   ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035866725

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 43.31%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 11 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-scala-tests|6|3|
   >|spark-java-tests|9|1|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   43.31%   -14.01%     
   + Complexity    18631    13869     -4762     
   =============================================
     Files          1955     1956        +1     
     Lines        106932   107014       +82     
     Branches      13231    13242       +11     
   =============================================
   - Hits          61291    46355    -14936     
   - Misses        39854    55310    +15456     
   + Partials       5787     5349      -438     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.95% <21.21%> (-13.54%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <21.21%> (-12.50%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `67.10% <ø> (-8.22%)` | :arrow_down: |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [792 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035857150

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 39.60%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 12 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-scala-tests|6|3|
   >|spark-java-tests|9|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   39.60%   -17.71%     
   + Complexity    18631    12630     -6001     
   =============================================
     Files          1955     1956        +1     
     Lines        106932   107014       +82     
     Branches      13231    13242       +11     
   =============================================
   - Hits          61291    42388    -18903     
   - Misses        39854    59529    +19675     
   + Partials       5787     5097      -690     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <21.21%> (-12.50%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `47.84% <ø> (-27.49%)` | :arrow_down: |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [865 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035915079

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `84.84848%` with `5 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.53%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 86.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   55.53%   -1.79%     
   + Complexity    18631    18023     -608     
   ============================================
     Files          1955     1956       +1     
     Lines        106932   107014      +82     
     Branches      13231    13242      +11     
   ============================================
   - Hits          61291    59430    -1861     
   - Misses        39854    41720    +1866     
   - Partials       5787     5864      +77     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.49% <84.84%> (-4.00%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <21.21%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `74.08% <ø> (-1.24%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `90.00% <86.66%> (-5.00%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `64.78% <62.50%> (-2.40%)` | :arrow_down: |
   
   ... and [242 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4030235713

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213",
       "triggerID" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12522",
       "triggerID" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 956e8bc6d3e0f9010f61cd0316527edc227aa318 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12522) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "KiteSoar (via GitHub)" <gi...@apache.org>.
KiteSoar commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035711533

   > [hudi-lance-bloom-refactoring.patch](https://github.com/user-attachments/files/25864461/hudi-lance-bloom-refactoring.patch) apply this patch please
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029762107

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `34 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 40.05%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (956e8bc). Click for more details.
   > 
   > <details><summary>HEAD has 13 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (956e8bc) |
   >|------|------|------|
   >|spark-scala-tests|6|2|
   >|spark-java-tests|9|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   40.05%   -17.26%     
   + Complexity    18631    12465     -6166     
   =============================================
     Files          1955     1938       -17     
     Lines        106932   104656     -2276     
     Branches      13231    12743      -488     
   =============================================
   - Hits          61291    41925    -19366     
   - Misses        39854    57773    +17919     
   + Partials       5787     4958      -829     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.39% <0.00%> (-12.20%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [866 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029756935

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `34 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 40.38%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (956e8bc). Click for more details.
   > 
   > <details><summary>HEAD has 14 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (956e8bc) |
   >|------|------|------|
   >|spark-scala-tests|6|1|
   >|spark-java-tests|9|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   40.38%   -16.93%     
   + Complexity    18631    12293     -6338     
   =============================================
     Files          1955     1921       -34     
     Lines        106932   102240     -4692     
     Branches      13231    12144     -1087     
   =============================================
   - Hits          61291    41294    -19997     
   - Misses        39854    56088    +16234     
   + Partials       5787     4858      -929     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.55% <0.00%> (-12.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [886 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029775138

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `34 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 43.33%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (956e8bc). Click for more details.
   > 
   > <details><summary>HEAD has 11 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (956e8bc) |
   >|------|------|------|
   >|spark-scala-tests|6|3|
   >|spark-java-tests|9|1|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   43.33%   -13.99%     
   + Complexity    18631    13863     -4768     
   =============================================
     Files          1955     1955               
     Lines        106932   106960       +28     
     Branches      13231    13233        +2     
   =============================================
   - Hits          61291    46349    -14942     
   - Misses        39854    55265    +15411     
   + Partials       5787     5346      -441     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.04% <0.00%> (-13.45%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <0.00%> (-12.49%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [784 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029841896

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `34 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 51.75%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (956e8bc). Click for more details.
   > 
   > <details><summary>HEAD has 8 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (956e8bc) |
   >|------|------|------|
   >|spark-scala-tests|6|4|
   >|spark-java-tests|9|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   51.75%   -5.57%     
   + Complexity    18631    16627    -2004     
   ============================================
     Files          1955     1955              
     Lines        106932   106960      +28     
     Branches      13231    13233       +2     
   ============================================
   - Hits          61291    55352    -5939     
   - Misses        39854    45625    +5771     
   - Partials       5787     5983     +196     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <0.00%> (-14.31%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <0.00%> (-0.23%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [523 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-3766366678

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188) 
   * 988bc9f20c46e5bff3e6e30bafc643b43d9076cd Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-3768601749

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213",
       "triggerID" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 988bc9f20c46e5bff3e6e30bafc643b43d9076cd Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195) 
   * f1149b5f90dd7e8030ce9ff5c4d898255cccb48e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035713163

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11188",
       "triggerID" : "691c7194dd924f2e9f0a1e76d7ec2a41fc1d1d7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11195",
       "triggerID" : "988bc9f20c46e5bff3e6e30bafc643b43d9076cd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11213",
       "triggerID" : "f1149b5f90dd7e8030ce9ff5c4d898255cccb48e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12522",
       "triggerID" : "956e8bc6d3e0f9010f61cd0316527edc227aa318",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3598ac9582779208efab962ca8b50bb6ed04539c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3598ac9582779208efab962ca8b50bb6ed04539c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 956e8bc6d3e0f9010f61cd0316527edc227aa318 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12522) 
   * 3598ac9582779208efab962ca8b50bb6ed04539c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4037070754

   @KiteSoar hi! Thanks for your contribution! But i close this PR if you don't mind. It'll be faster if I resolve this issue by myself (https://github.com/apache/hudi/pull/18304 )
   Please could you focus on finishing `canWrite` implementation (https://github.com/apache/hudi/pull/17831) ASAP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029866321

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `85.29412%` with `5 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.55%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 91.30% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   55.55%   -1.76%     
   + Complexity    18631    18012     -619     
   ============================================
     Files          1955     1955              
     Lines        106932   106960      +28     
     Branches      13231    13233       +2     
   ============================================
   - Hits          61291    59426    -1865     
   - Misses        39854    41668    +1814     
   - Partials       5787     5866      +79     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.50% <85.29%> (-3.99%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `91.52% <91.30%> (-3.48%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `64.78% <62.50%> (-2.40%)` | :arrow_down: |
   
   ... and [235 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4029861424

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `85.29412%` with `5 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.53%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`956e8bc`](https://app.codecov.io/gh/apache/hudi/commit/956e8bc6d3e0f9010f61cd0316527edc227aa318?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 62.50% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 91.30% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   55.53%   -1.79%     
   + Complexity    18631    18005     -626     
   ============================================
     Files          1955     1955              
     Lines        106932   106960      +28     
     Branches      13231    13233       +2     
   ============================================
   - Hits          61291    59395    -1896     
   - Misses        39854    41696    +1842     
   - Partials       5787     5869      +82     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.46% <85.29%> (-4.03%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `85.71% <100.00%> (+0.71%)` | :arrow_up: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `91.52% <91.30%> (-3.48%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `64.78% <62.50%> (-2.40%)` | :arrow_down: |
   
   ... and [244 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035879007

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 43.40%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 9 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-scala-tests|6|3|
   >|spark-java-tests|9|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   43.40%   -13.92%     
   + Complexity    18631    13895     -4736     
   =============================================
     Files          1955     1956        +1     
     Lines        106932   107014       +82     
     Branches      13231    13242       +11     
   =============================================
   - Hits          61291    46450    -14841     
   - Misses        39854    55232    +15378     
   + Partials       5787     5332      -455     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <21.21%> (-14.32%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <21.21%> (-12.50%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `67.10% <ø> (-8.22%)` | :arrow_down: |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [791 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035856641

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 40.04%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 13 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-scala-tests|6|2|
   >|spark-java-tests|9|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #17939       +/-   ##
   =============================================
   - Coverage     57.31%   40.04%   -17.28%     
   + Complexity    18631    12470     -6161     
   =============================================
     Files          1955     1939       -16     
     Lines        106932   104710     -2222     
     Branches      13231    12752      -479     
   =============================================
   - Hits          61291    41928    -19363     
   - Misses        39854    57822    +17968     
   + Partials       5787     4960      -827     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.38% <21.21%> (-12.21%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `47.84% <ø> (-27.49%)` | :arrow_down: |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [874 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: Support bloom filter in Lance writer [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17939:
URL: https://github.com/apache/hudi/pull/17939#issuecomment-4035905706

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `21.21212%` with `26 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 51.82%. Comparing base ([`b5daa30`](https://app.codecov.io/gh/apache/hudi/commit/b5daa30aed8c0f4d9f36a8a3ba7e62a2cbf86b98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3598ac9`](https://app.codecov.io/gh/apache/hudi/commit/3598ac9582779208efab962ca8b50bb6ed04539c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (b5daa30) and HEAD (3598ac9). Click for more details.
   > 
   > <details><summary>HEAD has 7 uploads less than BASE</summary>
   >
   >| Flag | BASE (b5daa30) | HEAD (3598ac9) |
   >|------|------|------|
   >|spark-scala-tests|6|5|
   >|spark-java-tests|9|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17939      +/-   ##
   ============================================
   - Coverage     57.31%   51.82%   -5.50%     
   + Complexity    18631    16660    -1971     
   ============================================
     Files          1955     1956       +1     
     Lines        106932   107014      +82     
     Branches      13231    13242      +11     
   ============================================
   - Hits          61291    55459    -5832     
   - Misses        39854    45579    +5725     
   - Partials       5787     5976     +189     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <0.00%> (-0.03%)` | :arrow_down: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <21.21%> (-14.32%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <21.21%> (-0.11%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../storage/row/HoodieBloomFilterRowWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieBloomFilterRowWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllQmxvb21GaWx0ZXJSb3dXcml0ZVN1cHBvcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...i/io/storage/row/HoodieRowParquetWriteSupport.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2FHoodieRowParquetWriteSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvSG9vZGllUm93UGFycXVldFdyaXRlU3VwcG9ydC5qYXZh) | `67.77% <ø> (-7.56%)` | :arrow_down: |
   | [.../hudi/io/storage/HoodieSparkFileWriterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkFileWriterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0ZpbGVXcml0ZXJGYWN0b3J5LmphdmE=) | `73.80% <0.00%> (-11.20%)` | :arrow_down: |
   | [...rg/apache/hudi/io/lance/HoodieBaseLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Flance%2FHoodieBaseLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL2xhbmNlL0hvb2RpZUJhc2VMYW5jZVdyaXRlci5qYXZh) | `0.00% <0.00%> (-67.19%)` | :arrow_down: |
   | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17939?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-95.00%)` | :arrow_down: |
   
   ... and [514 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org