You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@joshua.apache.org by mj...@apache.org on 2016/08/23 22:17:43 UTC
[26/50] [abbrv] incubator-joshua git commit: Fix Javadoc on master
branch
Fix Javadoc on master branch
Project: http://git-wip-us.apache.org/repos/asf/incubator-joshua/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-joshua/commit/ff410c29
Tree: http://git-wip-us.apache.org/repos/asf/incubator-joshua/tree/ff410c29
Diff: http://git-wip-us.apache.org/repos/asf/incubator-joshua/diff/ff410c29
Branch: refs/heads/7
Commit: ff410c297a149400db3cb553b11a930ad01dc7ed
Parents: ac465ef
Author: Lewis John McGibbney <le...@gmail.com>
Authored: Mon Aug 22 21:10:05 2016 -0700
Committer: Lewis John McGibbney <le...@gmail.com>
Committed: Mon Aug 22 21:10:05 2016 -0700
----------------------------------------------------------------------
.../org/apache/joshua/decoder/phrase/Candidate.java | 7 ++++---
.../apache/joshua/decoder/phrase/PhraseNodes.java | 15 +++++----------
.../java/org/apache/joshua/decoder/phrase/Stack.java | 1 -
3 files changed, 9 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-joshua/blob/ff410c29/src/main/java/org/apache/joshua/decoder/phrase/Candidate.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/joshua/decoder/phrase/Candidate.java b/src/main/java/org/apache/joshua/decoder/phrase/Candidate.java
index bc770f4..883bcfb 100644
--- a/src/main/java/org/apache/joshua/decoder/phrase/Candidate.java
+++ b/src/main/java/org/apache/joshua/decoder/phrase/Candidate.java
@@ -219,10 +219,11 @@ public class Candidate implements Comparable<Candidate> {
}
/**
- * Ensures that the cost of applying the edge has been computed. This is tucked away in an
- * accessor so that we can do it lazily if we wish.
+ * Ensures that the cost of applying the edge has been
+ * computed. This is tucked away in an accessor so that
+ * we can do it lazily if we wish.
*
- * @return
+ * @return the computed result.
*/
public ComputeNodeResult computeResult() {
if (computedResult == null) {
http://git-wip-us.apache.org/repos/asf/incubator-joshua/blob/ff410c29/src/main/java/org/apache/joshua/decoder/phrase/PhraseNodes.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/joshua/decoder/phrase/PhraseNodes.java b/src/main/java/org/apache/joshua/decoder/phrase/PhraseNodes.java
index c20c05a..c690dc3 100644
--- a/src/main/java/org/apache/joshua/decoder/phrase/PhraseNodes.java
+++ b/src/main/java/org/apache/joshua/decoder/phrase/PhraseNodes.java
@@ -45,19 +45,14 @@ public class PhraseNodes extends ArrayList<HGNode> {
}
/**
- * Score the rules and sort them. Scoring is necessary because rules are only scored if they
- * are used, in an effort to make reading in rules more efficient. This is starting to create
- * some trouble and should probably be reworked.
- *
- * @param features a {@link java.util.List} of {@link org.apache.joshua.decoder.ff.FeatureFunction}'s
- * @param weights a populated {@link org.apache.joshua.decoder.ff.FeatureVector}
- * @param num_options the number of options
+ * Score the rules and sort them. Scoring is necessary
+ * because rules are only scored if they are used, in an
+ * effort to make reading in rules more efficient.
+ * This is starting to create some trouble and should
+ * probably be reworked.
*/
public void finish() {
Collections.sort(this, HGNode.inverseLogPComparator);
-// System.err.println("TargetPhrases::finish()");
-// for (Rule rule: this)
-// System.err.println(" " + rule);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-joshua/blob/ff410c29/src/main/java/org/apache/joshua/decoder/phrase/Stack.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/joshua/decoder/phrase/Stack.java b/src/main/java/org/apache/joshua/decoder/phrase/Stack.java
index 47a3396..a16d9fe 100644
--- a/src/main/java/org/apache/joshua/decoder/phrase/Stack.java
+++ b/src/main/java/org/apache/joshua/decoder/phrase/Stack.java
@@ -57,7 +57,6 @@ public class Stack extends ArrayList<Hypothesis> {
/**
* Create a new stack. Stacks are organized one for each number of source words that are covered.
*
- * @param featureFunctions {@link java.util.List} of {@link org.apache.joshua.decoder.ff.FeatureFunction}'s
* @param sentence input for a {@link org.apache.joshua.lattice.Lattice}
* @param config populated {@link org.apache.joshua.decoder.JoshuaConfiguration}
*/