You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/01 07:40:51 UTC
[GitHub] [rocketmq-mqtt] tianliuliu opened a new pull request #47: [ISSUE #46] support prometheus collect lmq write read rt metrics
tianliuliu opened a new pull request #47:
URL: https://github.com/apache/rocketmq-mqtt/pull/47
fix #46 support prometheus collect lmq write read rt metrics and use GAUGE type to monitor rt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #47: [ISSUE #46] support prometheus collect lmq write read rt metrics
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #47:
URL: https://github.com/apache/rocketmq-mqtt/pull/47#issuecomment-1085592218
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#47](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b053cfe) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/ab353d08a959796090c8b0d33339fb5c42713b75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab353d0) will **increase** coverage by `0.01%`.
> The diff coverage is `22.22%`.
```diff
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 21.95% 21.97% +0.01%
==========================================
Files 96 96
Lines 4154 4178 +24
Branches 663 663
==========================================
+ Hits 912 918 +6
- Misses 3017 3035 +18
Partials 225 225
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/rocketmq/mqtt/ds/store/LmqQueueStoreManager.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9zdG9yZS9MbXFRdWV1ZVN0b3JlTWFuYWdlci5qYXZh) | `26.04% <0.00%> (-1.68%)` | :arrow_down: |
| [.../mqtt/exporter/collector/MqttMetricsCollector.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9leHBvcnRlci9jb2xsZWN0b3IvTXF0dE1ldHJpY3NDb2xsZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ketmq/mqtt/exporter/collector/MqttMetricsInfo.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9leHBvcnRlci9jb2xsZWN0b3IvTXF0dE1ldHJpY3NJbmZvLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/rocketmq/mqtt/ds/meta/WildcardManager.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tZXRhL1dpbGRjYXJkTWFuYWdlci5qYXZh) | `72.41% <85.71%> (+0.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ab353d0...b053cfe](https://codecov.io/gh/apache/rocketmq-mqtt/pull/47?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org