You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Mark Struberg (JIRA)" <ji...@apache.org> on 2010/03/18 11:10:27 UTC
[jira] Created: (OWB-330) reduce BeanManagerImpl#getManager() calls
inside the same functions
reduce BeanManagerImpl#getManager() calls inside the same functions
-------------------------------------------------------------------
Key: OWB-330
URL: https://issues.apache.org/jira/browse/OWB-330
Project: OpenWebBeans
Issue Type: Improvement
Components: Core
Affects Versions: M4
Reporter: Mark Struberg
Assignee: Mark Struberg
Priority: Minor
Fix For: 1.0.0
currently we use BeanManagerImpl.getManager() multiple times in the same function.
Profiling OWB with yourkit profiler unveiled that we call this function really often.
We should check all those occurrences and remove multiple invocations inside the same method.
Instead of
BeanManagerImpl.getManager().addBean(x);
BeanManagerImpl.getManager().addBean(y);
we should write:
BeanManagerImpl bm = BeanManagerImpl.getManager();
bm.addBean(x);
bm.addBean(y);
if possible
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OWB-330) reduce BeanManagerImpl#getManager()
calls inside the same functions
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg resolved OWB-330.
-------------------------------
Resolution: Fixed
check all occurrences. Currently this looks pretty well.
> reduce BeanManagerImpl#getManager() calls inside the same functions
> -------------------------------------------------------------------
>
> Key: OWB-330
> URL: https://issues.apache.org/jira/browse/OWB-330
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: M4
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Priority: Minor
> Fix For: 1.0.0
>
>
> currently we use BeanManagerImpl.getManager() multiple times in the same function.
> Profiling OWB with yourkit profiler unveiled that we call this function really often.
> We should check all those occurrences and remove multiple invocations inside the same method.
> Instead of
> BeanManagerImpl.getManager().addBean(x);
> BeanManagerImpl.getManager().addBean(y);
> we should write:
> BeanManagerImpl bm = BeanManagerImpl.getManager();
> bm.addBean(x);
> bm.addBean(y);
> if possible
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.