You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/31 07:24:35 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9054: ARROW-11082: [Rust] C data interface to largeUTF8
jorgecarleitao opened a new pull request #9054:
URL: https://github.com/apache/arrow/pull/9054
This also simplifies some code and adds a test for the boolean case, which is special due to bit-packing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9054: ARROW-11082: [Rust] C data interface to largeUTF8
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9054:
URL: https://github.com/apache/arrow/pull/9054#issuecomment-753275626
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9054?src=pr&el=h1) Report
> Merging [#9054](https://codecov.io/gh/apache/arrow/pull/9054?src=pr&el=desc) (3695980) into [master](https://codecov.io/gh/apache/arrow/commit/51672b28e97f19f70de0f0a8800c40ee9bb939d3?el=desc) (51672b2) will **increase** coverage by `0.01%`.
> The diff coverage is `85.29%`.
[](https://codecov.io/gh/apache/arrow/pull/9054?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9054 +/- ##
==========================================
+ Coverage 82.61% 82.62% +0.01%
==========================================
Files 202 202
Lines 50048 50068 +20
==========================================
+ Hits 41347 41370 +23
+ Misses 8701 8698 -3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9054?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow/pull/9054/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZmZpLnJz) | `72.45% <83.33%> (+2.17%)` | :arrow_up: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9054/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `90.05% <100.00%> (-0.22%)` | :arrow_down: |
| [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/9054/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `88.93% <0.00%> (+0.73%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9054?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9054?src=pr&el=footer). Last update [51672b2...3695980](https://codecov.io/gh/apache/arrow/pull/9054?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9054: ARROW-11082: [Rust] C data interface to largeUTF8
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9054:
URL: https://github.com/apache/arrow/pull/9054#issuecomment-752880441
https://issues.apache.org/jira/browse/ARROW-11082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9054: ARROW-11082: [Rust] C data interface to largeUTF8
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9054:
URL: https://github.com/apache/arrow/pull/9054#issuecomment-752956258
The full set of Rust CI tests did not run on this PR :(
Can you please rebase this PR against [apache/master](https://github.com/apache/arrow) to pick up the changes in https://github.com/apache/arrow/pull/9056 so that they do?
I apologize for the inconvenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #9054: ARROW-11082: [Rust] C data interface to largeUTF8
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #9054:
URL: https://github.com/apache/arrow/pull/9054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #9054: ARROW-11082: [Rust] C data interface to largeUTF8
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #9054:
URL: https://github.com/apache/arrow/pull/9054#discussion_r550738792
##########
File path: rust/arrow/src/ffi.rs
##########
@@ -624,10 +650,10 @@ mod tests {
}
// case with nulls is tested in the docs, through the example on this module.
- #[test]
- fn test_string() -> Result<()> {
+ fn test_genetic_string<Offset: StringOffsetSizeTrait>() -> Result<()> {
Review comment:
```suggestion
fn test_generic_string<Offset: StringOffsetSizeTrait>() -> Result<()> {
```
##########
File path: rust/arrow/src/ffi.rs
##########
@@ -654,4 +683,40 @@ mod tests {
// (drop/release)
Ok(())
}
+
+ #[test]
+ fn test_string() -> Result<()> {
+ test_genetic_string::<i32>()
+ }
+
+ #[test]
+ fn test_large_string() -> Result<()> {
+ test_genetic_string::<i64>()
+ }
+
+ #[test]
+ fn test_bool() -> Result<()> {
Review comment:
nice and neat :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org