You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/02/16 06:56:50 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #40052: [SPARK-42463][YARN][TESTS] Clean up the third-party Java source code copy introduced by SPARK-27180
LuciferYang opened a new pull request, #40052:
URL: https://github.com/apache/spark/pull/40052
### What changes were proposed in this pull request?
SPARK-27180 introduced some third-party Java source code to solve Yarn module test failure, but maven and sbt can also test pass without them, so this pr remove these files.
### Why are the changes needed?
Clean up the third-party Java source code copy in Spark.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Pass GitHub Actions
- manual check:
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #40052: [SPARK-42463][YARN][TESTS] Clean up the third-party Java files copy introduced by SPARK-27180
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #40052:
URL: https://github.com/apache/spark/pull/40052#issuecomment-1432653093
Could you test against hadoop-2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #40052: [SPARK-42463][YARN][TESTS] Clean up the third-party Java files copy introduced by SPARK-27180
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #40052: [SPARK-42463][YARN][TESTS] Clean up the third-party Java files copy introduced by SPARK-27180
URL: https://github.com/apache/spark/pull/40052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40052: [SPARK-42463][YARN][TESTS] Clean up the third-party Java files copy introduced by SPARK-27180
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40052:
URL: https://github.com/apache/spark/pull/40052#issuecomment-1432646662
cc @wangyum FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40052: [SPARK-42463][YARN][TESTS] Clean up the third-party Java files copy introduced by SPARK-27180
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40052:
URL: https://github.com/apache/spark/pull/40052#issuecomment-1432702958
> Could you test against hadoop-2?
Do these check with -Phadoop-2
**Maven**
```
build/mvn clean
build/mvn clean install -DskipTestes -pl resource-managers/yarn -am -Pyarn -Phadoop-2
build/mvn -Dtest=none -DwildcardSuites=org.apache.spark.deploy.yarn.YarnClusterSuite -pl resource-managers/yarn test -Pyarn -Phadoop-2
build/mvn test -pl resource-managers/yarn -Pyarn -Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest -Phadoop-2
```
**SBT**
```
build/sbt clean yarn/test -Pyarn -Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest -Phadoop-2
```
All tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40052: [SPARK-42463][YARN][TESTS] Clean up the third-party Java files copy introduced by SPARK-27180
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40052:
URL: https://github.com/apache/spark/pull/40052#issuecomment-1433264221
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org