You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/15 09:13:39 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4321: Support DML for SQLServer with visitor
terrymanu opened a new pull request #4321: Support DML for SQLServer with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4321
For #4318.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4321:
Support DML for SQLServer with visitor
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4321: Support DML for SQLServer with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4321#issuecomment-586572594
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4321?src=pr&el=h1) Report
> Merging [#4321](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4321?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/18e9025c179b853b3c26511f770056e9f36af75e?src=pr&el=desc) will **decrease** coverage by `0.56%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4321?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4321 +/- ##
============================================
- Coverage 56.52% 55.95% -0.57%
Complexity 352 352
============================================
Files 1030 1031 +1
Lines 18383 18570 +187
Branches 3347 3382 +35
============================================
Hits 10391 10391
- Misses 7337 7524 +187
Partials 655 655
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4321?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4321/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvU1FMU2VydmVyRE1MVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4321?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4321?src=pr&el=footer). Last update [18e9025...a5dbaef](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4321?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4321:
Support DML for SQLServer with visitor
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4321: Support DML for SQLServer with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4321:
Support DML for SQLServer with visitor
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4321: Support DML for SQLServer with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4321#issuecomment-586572822
## Pull Request Test Coverage Report for [Build 9563](https://coveralls.io/builds/28749912)
* **0** of **186** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.6%**) to **59.537%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/28749912/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L94) | 0 | 186 | 0.0%
<!-- | **Total:** | **0** | **186** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/28749912/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L90) | 1 | 0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/28749912) |
| :-- | --: |
| Change from base [Build 9560](https://coveralls.io/builds/28749196): | -0.6% |
| Covered Lines: | 11056 |
| Relevant Lines: | 18570 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services