You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/05/14 02:55:40 UTC
Review Request 34184: DRILL-3065: Memory Leak at ExternalSortBatch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34184/
-----------------------------------------------------------
Review request for drill, abdelhakim deneche and Jinfeng Ni.
Bugs: DRILL-3065
https://issues.apache.org/jira/browse/DRILL-3065
Repository: drill-git
Description
-------
Clean the SelectionVector4 in mSort after failure happens
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java 529a6ca
Diff: https://reviews.apache.org/r/34184/diff/
Testing
-------
Unit test passed; Others are running
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 34184: DRILL-3065: Memory Leak at ExternalSortBatch
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34184/
-----------------------------------------------------------
(Updated May 14, 2015, 9:58 p.m.)
Review request for drill, abdelhakim deneche and Jinfeng Ni.
Changes
-------
This patch resolves DRILL-3065 & 3085
Bugs: DRILL-3065
https://issues.apache.org/jira/browse/DRILL-3065
Repository: drill-git
Description
-------
Clean the SelectionVector4 in mSort after failure happens
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java 529a6ca
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java 9acae9e
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSorter.java d97ffc0
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java f95fbe1
Diff: https://reviews.apache.org/r/34184/diff/
Testing
-------
Unit test passed; Others are running
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 34184: DRILL-3065: Memory Leak at ExternalSortBatch
Posted by abdelhakim deneche <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34184/#review83703
-----------------------------------------------------------
Can you include a unit test that exposes this problem ?
- abdelhakim deneche
On May 14, 2015, 12:55 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34184/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 12:55 a.m.)
>
>
> Review request for drill, abdelhakim deneche and Jinfeng Ni.
>
>
> Bugs: DRILL-3065
> https://issues.apache.org/jira/browse/DRILL-3065
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Clean the SelectionVector4 in mSort after failure happens
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java 529a6ca
>
> Diff: https://reviews.apache.org/r/34184/diff/
>
>
> Testing
> -------
>
> Unit test passed; Others are running
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>