You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/26 18:04:13 UTC
Re: Review Request 32982: Added reservation user guide.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 26, 2015, 4:04 p.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Summary (updated)
-----------------
Added reservation user guide.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
See summary.
NOTE: The framework API should be reviewed thoroughly at this point since those have been implemented and landed.
The master API endpoints however are still in development and therefore the state reflected in this patch is incomplete. (e.g. what HTTP code do we return on failures?)
I'll update the guide to accurately reflect the master endpoints as it gets more solified.
The purpose of including it was/is to get initial feedback on how it generally works.
Diffs (updated)
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89551
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32982]
All tests passed.
- Mesos ReviewBot
On June 26, 2015, 7:53 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 7:53 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89562
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32982]
All tests passed.
- Mesos ReviewBot
On June 26, 2015, 8:43 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 8:43 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89654
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32982]
All tests passed.
- Mesos ReviewBot
On June 28, 2015, 3:33 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 28, 2015, 3:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
> On June 28, 2015, 11:36 p.m., Benjamin Hindman wrote:
> > I made a few minor tweaks here before committing.
> >
> > (1) Replaced the fenced code blocks with indented code blocks so that the doxygen generated markdown was readable.
> > (2) Made all the 'Coming Soon' be styled consistently (I went with one _, if you'd prefer the ___ underscore instead we can swap).
> > (3) Made the shell examples be copyable to an actual shell by adding line continuations, i.e., \.
Thanks for doing that Ben,
(1) Thanks,
(2) Yeah, I left it as _ in the header because the boldness part didn't seem to have any effect in its rendering. I would probably prefer the ___ since that's what we use in `Getting Started` as well for (___Recommended___) and, (___Advanced Users Only___)
(3) Sweet!
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89689
-----------------------------------------------------------
On June 28, 2015, 3:33 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 28, 2015, 3:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89689
-----------------------------------------------------------
Ship it!
I made a few minor tweaks here before committing.
(1) Replaced the fenced code blocks with indented code blocks so that the doxygen generated markdown was readable.
(2) Made all the 'Coming Soon' be styled consistently (I went with one _, if you'd prefer the ___ underscore instead we can swap).
(3) Made the shell examples be copyable to an actual shell by adding line continuations, i.e., \.
- Benjamin Hindman
On June 28, 2015, 3:33 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 28, 2015, 3:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
> On June 29, 2015, 11:43 p.m., Adam B wrote:
> > docs/reservation.md, line 108
> > <https://reviews.apache.org/r/32982/diff/12/?file=994059#file994059line108>
> >
> > I know that we'll want to explicitly specify the role to support future multi-role frameworks, but why does this need to be included now?
There were 2 motivations for this. First is what you said, the second was that we can enforce the field to be `required` this way.
> On June 29, 2015, 11:43 p.m., Adam B wrote:
> > docs/reservation.md, lines 109-110
> > <https://reviews.apache.org/r/32982/diff/12/?file=994059#file994059line109>
> >
> > Shouldn't the master be able to determine the principal that this frameworkId is currently authenticated as? Why even allow the framework to specify a different principal if you're just going to Error?
Hm, that's true. This was another situation where I wanted to keep `ReservationInfo.principal` as `required`.
> On June 29, 2015, 11:43 p.m., Adam B wrote:
> > docs/reservation.md, line 196
> > <https://reviews.apache.org/r/32982/diff/12/?file=994059#file994059line196>
> >
> > Could also only unreserve a subset, right?
Yeah, that's true. I didn't really mention that part.
> On June 29, 2015, 11:43 p.m., Adam B wrote:
> > docs/reservation.md, line 309
> > <https://reviews.apache.org/r/32982/diff/12/?file=994059#file994059line309>
> >
> > How can there be insufficient resources to unreserve?
The simplest case would be: if we have 4 dynamically reserved cpus and the request is to unreserve 6 dynamically reserved cpus. We don't simply unreserve the portion we can. A slightly more complicated case would be: if we have 4 dynamically reserved cpus and the request is to unreserve 4 dynamically reserved cpus, but 2 of them are currently being used. As we don't currently pre-empt tasks, it results in a `Conflict` for us currently.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89824
-----------------------------------------------------------
On June 28, 2015, 3:33 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 28, 2015, 3:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Adam B <ad...@mesosphere.io>.
> On June 29, 2015, 4:43 p.m., Adam B wrote:
> > Looks great! I know this is already committed, but I had a few questions/clarifications. Maybe you've answered these elsewhere, but I've been out of the loop for a while.
Thanks for answering my questions. I don't think there's anything that really warrants an edit/update.
> On June 29, 2015, 4:43 p.m., Adam B wrote:
> > docs/reservation.md, lines 109-110
> > <https://reviews.apache.org/r/32982/diff/12/?file=994059#file994059line109>
> >
> > Shouldn't the master be able to determine the principal that this frameworkId is currently authenticated as? Why even allow the framework to specify a different principal if you're just going to Error?
>
> Michael Park wrote:
> Hm, that's true. This was another situation where I wanted to keep `ReservationInfo.principal` as `required`.
Fair enough, although it seems like you're leaking the internal data representation into the user-facing API. Shouldn't be necessary.
> On June 29, 2015, 4:43 p.m., Adam B wrote:
> > docs/reservation.md, line 196
> > <https://reviews.apache.org/r/32982/diff/12/?file=994059#file994059line196>
> >
> > Could also only unreserve a subset, right?
>
> Michael Park wrote:
> Yeah, that's true. I didn't really mention that part.
Not terribly important. Anybody familiar with using resource offers should be able to figure that one out.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89824
-----------------------------------------------------------
On June 27, 2015, 8:33 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 27, 2015, 8:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89824
-----------------------------------------------------------
Looks great! I know this is already committed, but I had a few questions/clarifications. Maybe you've answered these elsewhere, but I've been out of the loop for a while.
docs/reservation.md (line 108)
<https://reviews.apache.org/r/32982/#comment142624>
I know that we'll want to explicitly specify the role to support future multi-role frameworks, but why does this need to be included now?
docs/reservation.md (lines 109 - 110)
<https://reviews.apache.org/r/32982/#comment142623>
Shouldn't the master be able to determine the principal that this frameworkId is currently authenticated as? Why even allow the framework to specify a different principal if you're just going to Error?
docs/reservation.md (line 196)
<https://reviews.apache.org/r/32982/#comment142625>
Could also only unreserve a subset, right?
docs/reservation.md (line 248)
<https://reviews.apache.org/r/32982/#comment142626>
Again, if we're already authenticating as a certain principal in the request, why do we need to explicitly specify a (potentially different?) principal in the resources message?
docs/reservation.md (line 309)
<https://reviews.apache.org/r/32982/#comment142627>
How can there be insufficient resources to unreserve?
- Adam B
On June 27, 2015, 8:33 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 27, 2015, 8:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 28, 2015, 3:33 a.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description (updated)
-------
The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md)
Diffs
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 28, 2015, 3:28 a.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description (updated)
-------
The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md)
Diffs
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 28, 2015, 3:27 a.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Changes
-------
Rebased.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
The Github rendered version is available at: https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md
Diffs (updated)
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 28, 2015, 3:23 a.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Changes
-------
Conform to the Mesos Markdown Style.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
The Github rendered version is available at: https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 3aa9487bed2df038ca27a8bb94c24608ca7910a4
3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 967201888114e01f1a2d3c9cfaae847f1ce42d13
3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp bba8303347aac3f70566a9e69625a928cfb1bd24
3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 5d0970fe9f712d7162eec522c83905292892c94d
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp ae54566b9d0160def6146aa0ce634bdbf0967142
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 4e8c3bd1e9abf0ff24f78c8385ed9625719dcf8c
3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp f766359fdd5a75e3a80d19be3e5c233e87357bde
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp a0ea23797376288e8dc96886fd3c0702e5edf846
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 818560f8ce20126e0aa4af6ce368c973c9616c74
3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp c6cfb60272d3754fdfdd4a8f9eefe56458d9cbf7
3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 5570d62729453a639a94c5569eb510ff2f1395a1
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 784104f26ceee2ef90709056a5f4428d48390c36
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp fed005e0bbbcfb7a8a9e4cccf1e47e1ab3d91394
3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp dfb2d948f2c20d02f179b4137e59d15a8b3b9c3b
3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 0e94e22817e21fc7944a995092e54bf302ab0e2c
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp a4afdad0b5f053186ace4d6a37b41cd02e7d415b
3rdparty/libprocess/3rdparty/stout/include/stout/preprocessor.hpp 11ec3d5349e2087f7352ebadf247ad509ab11c17
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 8c75f6b28c18596018eaefe427b238424aae2fd9
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 963029bea989a68a484f7b8b47d29ea5fffeb955
3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 8934ba79685685d5f5eae5991057c6ad3c8eea8e
3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 552d6e97c882a36d6a889af205c422e51f544b34
3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 5ad611497a47be64c539e832b9a1c23e6cf9586d
3rdparty/libprocess/3rdparty/stout/include/stout/utils.hpp faca859969a95b51d5fda5542d11906ff03dcf00
3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8a0ba5fc004c1dae265aa17e2a014279cd97281
3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b199dc8e8ed538ad771504f0dbee4132fe7
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b9636b9a4e2be57465eea01af6cbc867be
3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31b30ea3fb26d9ca3126daa26a325b61daf
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b6f32403fc2e167364744bb13b2e4969e2
3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a716788ed58db35e9fbe5621c07a40d89e7674
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f080a08c203c8986ebbcb92540047ecfabca
3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99df5fcf015b9dcc84f12798f8e2532e377
3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf746445704cbf4102989cc9fb911a2f6ab3
3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be3640fe896f66565760d93344cf0c264b9
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp d87cf22dbb98e1ac99f129668ad984a1542e4ec9
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942cdebc2797b42ac4cf0ffd5b202c9733bf6
3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5db57581e0392b31d8187531a9b672d47b
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4a01d9481c02ccbee323fd7e1319b811d344fb1d
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 3211a0d6b88d06b396678eaf20128698f576d198
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700dc928c3da97d96b8974cf2f3fd9f3b91f8
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131c8d346042f0c49f09873c246d44dbb3bb
3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp 3ddba94b30e4cba1a7b7bba5722ef3937cd582da
3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 0689446e34d16014aa846796426dad2e9f034215
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2ec5d68605b694210c66144b8d9f8c36467
3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 4519b4d03edb9c474b7f21650b92d5cc3183c323
3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp 2ac7a224f3a572893730effc75b9c2ea9732dff0
3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 93339ebd270c12e395530f6e237a424ce136c371
3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0eb619f1077bf2b86eaa33c4be37fa3823
3rdparty/libprocess/Makefile.am 358893c56929d98aa1b61ce289342be6098dd029
3rdparty/libprocess/include/process/socket.hpp f53d2e1dbb31e135c8951145d379cbbff3044448
3rdparty/libprocess/src/libevent.hpp 47b93f16f090b8bf288af3717db4502f13332af7
3rdparty/libprocess/src/openssl.cpp 6ff4adb4c9792ff10d8c6ed2f3b2f3d8d0d7f1a8
3rdparty/libprocess/src/tests/ssl_client.cpp 4e91bdad9349f6f7a04c57ead5f933f51d570845
3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22
docs/reservation.md PRE-CREATION
src/common/protobuf_utils.cpp 9ccd70d350babe1c1532bbe8da2fda0f5d9269a5
src/sched/sched.cpp a4e35aad2fd585a65c3188e018cf083daf3ef701
src/slave/slave.cpp b8591116eadcd68b8db2a629fbcf793e6b394f14
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 27, 2015, 2:32 a.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Changes
-------
Added link to rendered version.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description (updated)
-------
The Github rendered version is available at: https://github.com/mesosphere/mesos/blob/reservation-user-doc/docs/reservation.md
Diffs
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 26, 2015, 8:43 p.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 26, 2015, 8:35 p.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 26, 2015, 8:33 p.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 26, 2015, 7:53 p.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 26, 2015, 6:13 p.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description (updated)
-------
See summary.
Diffs
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89532
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32982]
All tests passed.
- Mesos ReviewBot
On June 26, 2015, 6:12 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 6:12 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
> NOTE: The framework API should be reviewed thoroughly at this point since those have been implemented and landed.
> The master API endpoints however are still in development and therefore the state reflected in this patch is incomplete. (e.g. what HTTP code do we return on failures?)
> I'll update the guide to accurately reflect the master endpoints as it gets more solified.
> The purpose of including it was/is to get initial feedback on how it generally works.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 26, 2015, 6:12 p.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Changes
-------
Iterated on the API for frameworks.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
See summary.
NOTE: The framework API should be reviewed thoroughly at this point since those have been implemented and landed.
The master API endpoints however are still in development and therefore the state reflected in this patch is incomplete. (e.g. what HTTP code do we return on failures?)
I'll update the guide to accurately reflect the master endpoints as it gets more solified.
The purpose of including it was/is to get initial feedback on how it generally works.
Diffs (updated)
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 26, 2015, 5:04 p.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
See summary.
NOTE: The framework API should be reviewed thoroughly at this point since those have been implemented and landed.
The master API endpoints however are still in development and therefore the state reflected in this patch is incomplete. (e.g. what HTTP code do we return on failures?)
I'll update the guide to accurately reflect the master endpoints as it gets more solified.
The purpose of including it was/is to get initial feedback on how it generally works.
Diffs (updated)
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
-----------------------------------------------------------
(Updated June 26, 2015, 4:54 p.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
Changes
-------
Addressed a few comments, marked master endpoints as `(Coming Soon)`, reordered to describe the interfaces for the framework first.
Bugs: MESOS-2205
https://issues.apache.org/jira/browse/MESOS-2205
Repository: mesos
Description
-------
See summary.
NOTE: The framework API should be reviewed thoroughly at this point since those have been implemented and landed.
The master API endpoints however are still in development and therefore the state reflected in this patch is incomplete. (e.g. what HTTP code do we return on failures?)
I'll update the guide to accurately reflect the master endpoints as it gets more solified.
The purpose of including it was/is to get initial feedback on how it generally works.
Diffs (updated)
-----
docs/reservation.md PRE-CREATION
Diff: https://reviews.apache.org/r/32982/diff/
Testing
-------
Documentation.
Thanks,
Michael Park
Re: Review Request 32982: Added reservation user guide.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89512
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32982]
All tests passed.
- Mesos ReviewBot
On June 26, 2015, 4:04 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32982/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 4:04 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-2205
> https://issues.apache.org/jira/browse/MESOS-2205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
> NOTE: The framework API should be reviewed thoroughly at this point since those have been implemented and landed.
> The master API endpoints however are still in development and therefore the state reflected in this patch is incomplete. (e.g. what HTTP code do we return on failures?)
> I'll update the guide to accurately reflect the master endpoints as it gets more solified.
> The purpose of including it was/is to get initial feedback on how it generally works.
>
>
> Diffs
> -----
>
> docs/reservation.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32982/diff/
>
>
> Testing
> -------
>
> Documentation.
>
>
> Thanks,
>
> Michael Park
>
>