You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/07/16 09:46:48 UTC
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17689
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
Two Iceberg commits got into master branch in parallel. One of
them modified the DDL syntax, the other one added some tests.
They were correct on their own, but mixing the two causes
test failures.
The affected tests have been updated.
Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-catalogs.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
2 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/17689/1
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7314/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 15:55:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7312/
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 14:29:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7307/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 11:04:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
Two Iceberg commits got into master branch in parallel. One of
them modified the DDL syntax, the other one added some tests.
They were correct on their own, but mixing the two causes
test failures.
The affected tests have been updated.
Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Reviewed-on: http://gerrit.cloudera.org:8080/17689
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-catalogs.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
2 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9104/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 10:07:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 10:52:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7307/
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 17:07:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 08:09:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7312/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 08:09:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10802: test show create table and test catalogs fails with Iceberg syntax error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17689 )
Change subject: IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Gerrit-Change-Number: 17689
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 22:16:17 +0000
Gerrit-HasComments: No