[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #4826: Nessie: Use unique path for different table with same name

[GitBox <gi...@apache.org>]

ajantha-bhat commented on code in PR #4826:
URL: https://github.com/apache/iceberg/pull/4826#discussion_r910564868


##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -157,19 +161,21 @@ public TableBuilder withProperty(String key, String value) {
       return this;
     }
 
+    protected TableMetadata newTableMetadata() {
+      String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);

Review Comment:
   @rdblue:  Yes, overriding  `defaultWarehouseLocation` can solve the problem of two different tables with same identifier getting the same path (issue which this PR is trying to solve)
   
   But `defaultWarehouseLocation()` is the public interface of the catalog. 
   If user calls it `defaultWarehouseLocation()` N times for a table, then it gives N different location. Which is confusing.
    
   So, Instead of overrding it, I fixed as described in the PR.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org