You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Steve Loughran <st...@hortonworks.com> on 2015/06/01 12:40:58 UTC

Re: please use SparkFunSuite instead of ScalaTest's FunSuite from now on

Is this backported to branch 1.3?

On 31 May 2015, at 00:44, Reynold Xin <rx...@databricks.com>> wrote:

FYI we merged a patch that improves unit test log debugging. In order for that to work, all test suites have been changed to extend SparkFunSuite instead of ScalaTest's FunSuite. We also added a rule in the Scala style checker to fail Jenkins if FunSuite is used.

The patch that introduced SparkFunSuite: https://github.com/apache/spark/pull/6441

Style check patch: https://github.com/apache/spark/pull/6510



Re: please use SparkFunSuite instead of ScalaTest's FunSuite from now on

Posted by Steve Loughran <st...@hortonworks.com>.
thanks. All I'd need would be the base class, so that new tests can be written to work across branches.

-steve

On 1 Jun 2015, at 18:45, Andrew Or <an...@databricks.com>> wrote:

It will be within the next few days

2015-06-01 9:17 GMT-07:00 Reynold Xin <rx...@databricks.com>>:
I don't think so.


On Monday, June 1, 2015, Steve Loughran <st...@hortonworks.com>> wrote:
Is this backported to branch 1.3?

On 31 May 2015, at 00:44, Reynold Xin <rx...@databricks.com> wrote:

FYI we merged a patch that improves unit test log debugging. In order for that to work, all test suites have been changed to extend SparkFunSuite instead of ScalaTest's FunSuite. We also added a rule in the Scala style checker to fail Jenkins if FunSuite is used.

The patch that introduced SparkFunSuite: https://github.com/apache/spark/pull/6441

Style check patch: https://github.com/apache/spark/pull/6510





Re: please use SparkFunSuite instead of ScalaTest's FunSuite from now on

Posted by Andrew Or <an...@databricks.com>.
It will be within the next few days

2015-06-01 9:17 GMT-07:00 Reynold Xin <rx...@databricks.com>:

> I don't think so.
>
>
> On Monday, June 1, 2015, Steve Loughran <st...@hortonworks.com> wrote:
>
>>  Is this backported to branch 1.3?
>>
>>  On 31 May 2015, at 00:44, Reynold Xin <rx...@databricks.com> wrote:
>>
>>  FYI we merged a patch that improves unit test log debugging. In order
>> for that to work, all test suites have been changed to extend SparkFunSuite
>> instead of ScalaTest's FunSuite. We also added a rule in the Scala style
>> checker to fail Jenkins if FunSuite is used.
>>
>>  The patch that introduced SparkFunSuite:
>> https://github.com/apache/spark/pull/6441
>>
>>  Style check patch: https://github.com/apache/spark/pull/6510
>>
>>
>>

Re: please use SparkFunSuite instead of ScalaTest's FunSuite from now on

Posted by Reynold Xin <rx...@databricks.com>.
I don't think so.

On Monday, June 1, 2015, Steve Loughran <st...@hortonworks.com> wrote:

>  Is this backported to branch 1.3?
>
>  On 31 May 2015, at 00:44, Reynold Xin <rxin@databricks.com
> <javascript:_e(%7B%7D,'cvml','rxin@databricks.com');>> wrote:
>
>  FYI we merged a patch that improves unit test log debugging. In order
> for that to work, all test suites have been changed to extend SparkFunSuite
> instead of ScalaTest's FunSuite. We also added a rule in the Scala style
> checker to fail Jenkins if FunSuite is used.
>
>  The patch that introduced SparkFunSuite:
> https://github.com/apache/spark/pull/6441
>
>  Style check patch: https://github.com/apache/spark/pull/6510
>
>
>