You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by DoingDone9 <gi...@git.apache.org> on 2015/04/30 03:29:15 UTC

[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

GitHub user DoingDone9 opened a pull request:

    https://github.com/apache/spark/pull/5797

    [SPARK-7267][SQL]Push down Project when it's child is Limit

    SQL
    ```
    select key from (select key,value from t1 limit 100) t2 limit 10
    ```
    Optimized Logical Plan before modifying
    ```
    == Optimized Logical Plan ==
    Limit 10
      Project key#228
        Limit 100
          MetastoreRelation default, t1, None
    ```
    Optimized Logical Plan after modifying
    ```
    == Optimized Logical Plan ==
    Limit 10
      Limit 100
        Project key#228
          MetastoreRelation default, t1, None
    ```
    After this, we can combine limits

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DoingDone9/spark ProjectLimit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5797.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5797
    
----
commit c3f046f8de7c418d4aa7e74afea9968a8baf9231
Author: DoingDone9 <79...@qq.com>
Date:   2015-03-02T02:11:18Z

    Merge pull request #1 from apache/master
    
    merge lastest spark

commit cb1852d14f62adbd194b1edda4ec639ba942a8ba
Author: DoingDone9 <79...@qq.com>
Date:   2015-03-05T07:05:10Z

    Merge pull request #2 from apache/master
    
    merge lastest spark

commit c87e8b6d8cb433376a7d14778915006c31f6c01c
Author: DoingDone9 <79...@qq.com>
Date:   2015-03-10T07:46:12Z

    Merge pull request #3 from apache/master
    
    merge lastest spark

commit 161cae3a29951d793ce721f9904888bd9529de72
Author: DoingDone9 <79...@qq.com>
Date:   2015-03-12T06:46:28Z

    Merge pull request #4 from apache/master
    
    merge lastest spark

commit 98b134f39ca57f11a5b761c7b9e5f8a7477bd069
Author: DoingDone9 <79...@qq.com>
Date:   2015-03-19T09:00:07Z

    Merge pull request #5 from apache/master
    
    merge lastest spark

commit d00303b7af9436b9bd6d6d27d411a5c8a2e2294d
Author: DoingDone9 <79...@qq.com>
Date:   2015-03-24T08:43:44Z

    Merge pull request #6 from apache/master
    
    merge lastest spark

commit 802261c043f56bd5ebe9e46b15e33cdc7c212176
Author: DoingDone9 <79...@qq.com>
Date:   2015-03-26T02:21:24Z

    Merge pull request #7 from apache/master
    
    merge lastest spark

commit 34b1a9a8a30f689b41fd52b8a10c08666c2ff2b5
Author: Zhongshuai Pei <79...@qq.com>
Date:   2015-04-08T07:55:24Z

    Merge pull request #8 from apache/master
    
    merge lastest spark

commit f61210c03f693a266969e06c52c23ccd1bfe3e1b
Author: Zhongshuai Pei <79...@qq.com>
Date:   2015-04-17T09:10:48Z

    Merge pull request #9 from apache/master
    
    merge lastest spark

commit f12fa50a675ed490be728c2b0389db47a8a0f990
Author: Zhongshuai Pei <79...@qq.com>
Date:   2015-04-21T06:23:53Z

    Merge pull request #10 from apache/master
    
    merge lastest spark

commit f03fe7f9cff7a60b535ce8e33310655294e8b4a2
Author: Zhongshuai Pei <79...@qq.com>
Date:   2015-04-29T06:17:58Z

    Merge pull request #12 from apache/master
    
    merge lastest spark

commit 485c61cadd3bf0c8c55043846838d5f36eba5a61
Author: Zhongshuai Pei <79...@qq.com>
Date:   2015-04-29T09:16:18Z

    Update Optimizer.scala

commit dc83ae9dcb4df19959fe9add34c08203b05ed7b0
Author: Zhongshuai Pei <79...@qq.com>
Date:   2015-04-30T01:27:08Z

    Update FilterPushdownSuite.scala

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97715468
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97630345
  
    Jenkins, test this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97715469
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31396/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97629054
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97669998
  
    Retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97988778
  
    Thanks. Merging in master.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97715442
  
      [Test build #31396 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31396/consoleFull) for   PR 5797 at commit [`70d0fca`](https://github.com/apache/spark/commit/70d0fca415a6041b7ba39f4e8af01fa1147a551a).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.
     * This patch **adds the following new dependencies:**
       * `jaxb-api-2.2.7.jar`
       * `jaxb-core-2.2.7.jar`
       * `jaxb-impl-2.2.7.jar`
       * `pmml-agent-1.1.15.jar`
       * `pmml-model-1.1.15.jar`
       * `pmml-schema-1.1.15.jar`
    
     * This patch **removes the following dependencies:**
       * `activation-1.1.jar`
       * `jaxb-api-2.2.2.jar`
       * `jaxb-impl-2.2.3-1.jar`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97688351
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97633992
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31367/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97631049
  
      [Test build #31367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31367/consoleFull) for   PR 5797 at commit [`dc83ae9`](https://github.com/apache/spark/commit/dc83ae9dcb4df19959fe9add34c08203b05ed7b0).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/5797


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97689610
  
      [Test build #31396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31396/consoleFull) for   PR 5797 at commit [`70d0fca`](https://github.com/apache/spark/commit/70d0fca415a6041b7ba39f4e8af01fa1147a551a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97688243
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97630510
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97630487
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97633976
  
      [Test build #31367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31367/consoleFull) for   PR 5797 at commit [`dc83ae9`](https://github.com/apache/spark/commit/dc83ae9dcb4df19959fe9add34c08203b05ed7b0).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.
     * This patch does not change any dependencies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97633990
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7267][SQL]Push down Project when it's c...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/5797#issuecomment-97685444
  
    Jenkins, test this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org