You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/27 00:27:11 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7560: [AIRFLOW-6936]
Do not register a signal when a schedule job is stopped
mik-laj opened a new pull request #7560: [AIRFLOW-6936] Do not register a signal when a schedule job is stopped
URL: https://github.com/apache/airflow/pull/7560
We use these signals to stop child processes, so we should register them before running the child process.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7560: [AIRFLOW-6936] Do
not register a signal when a schedule job is stopped
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7560: [AIRFLOW-6936] Do not register a signal when a schedule job is stopped
URL: https://github.com/apache/airflow/pull/7560#issuecomment-591754997
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7560?src=pr&el=h1) Report
> Merging [#7560](https://codecov.io/gh/apache/airflow/pull/7560?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/835d8596a3d8752a4900d7153e2a75efdbb79668?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7560?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7560 +/- ##
==========================================
- Coverage 86.81% 86.53% -0.28%
==========================================
Files 896 896
Lines 42656 42658 +2
==========================================
- Hits 37033 36916 -117
- Misses 5623 5742 +119
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7560?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7560/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.1% <100%> (+0.02%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7560/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7560/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7560/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7560/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7560/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7560?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7560?src=pr&el=footer). Last update [835d859...17fefa5](https://codecov.io/gh/apache/airflow/pull/7560?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb merged pull request #7560: [AIRFLOW-6936] Only
register signal hanlders when ScheduleJob is started
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #7560: [AIRFLOW-6936] Only register signal hanlders when ScheduleJob is started
URL: https://github.com/apache/airflow/pull/7560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7560: [AIRFLOW-6936] Only
register signal hanlders when ScheduleJob is started
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7560: [AIRFLOW-6936] Only register signal hanlders when ScheduleJob is started
URL: https://github.com/apache/airflow/pull/7560#issuecomment-591882481
This change is fine, but in normal operation (i.e. `airflow scheduler`) the previous singal handlers were still working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services