You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/12 07:20:03 UTC
[GitHub] [apisix-website] guoqqqi opened a new pull request #716: feat: add Datadog plugin card in plugin hub
guoqqqi opened a new pull request #716:
URL: https://github.com/apache/apisix-website/pull/716
Fixes: #[Add issue number here]
1. add Datadog plugin card
2. update the icon
<!-- Add here what changes were made in this pull request and if possible provide links showcasing the changes. -->
Screenshots of the change:
<!-- Add screenshots depicting the changes. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #716: feat: add Datadog plugin card in plugin hub
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #716:
URL: https://github.com/apache/apisix-website/pull/716#issuecomment-966880270
cc @bzp2010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #716: feat: add Datadog plugin card in plugin hub
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #716:
URL: https://github.com/apache/apisix-website/pull/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bisakhmondal commented on a change in pull request #716: feat: add Datadog plugin card in plugin hub
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #716:
URL: https://github.com/apache/apisix-website/pull/716#discussion_r748805428
##########
File path: website/static/data/plugin.json
##########
@@ -145,6 +145,10 @@
{
"name": "zipkin",
"description": "Zipkin is a OpenTracing plugin"
+ },
+ {
+ "name": "datadog",
+ "description": "Datadog is a monitoring plugin built into Apache APISIX for seamless integration with Datadog"
Review comment:
How about
> `Datadog` is a monitoring plugin built into Apache APISIX to push metrics of different services into DatadogHQ via a locally run Datadog agent.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #716: feat: add Datadog plugin card in plugin hub
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #716:
URL: https://github.com/apache/apisix-website/pull/716#issuecomment-968255551
> 1. Keep the https://apisix.apache.org/plugins/ page using the stable plugins link;
> 2. Adding a mark or note on Datadog, and saying this plugin is in the Next Version of Apache APISIX.
Right, makes sense. We could put a `beta` tag over such plugin cards, like a notification badge, until that particular APISIX version releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi removed a comment on pull request #716: feat: add Datadog plugin card in plugin hub
Posted by GitBox <gi...@apache.org>.
guoqqqi removed a comment on pull request #716:
URL: https://github.com/apache/apisix-website/pull/716#issuecomment-966883922
wait #715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #716: feat: add Datadog plugin card in plugin hub
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #716:
URL: https://github.com/apache/apisix-website/pull/716#discussion_r748672571
##########
File path: website/static/data/plugin.json
##########
@@ -145,6 +145,10 @@
{
"name": "zipkin",
"description": "Zipkin is a OpenTracing plugin"
+ },
+ {
+ "name": "datadog",
+ "description": "Datadog is a monitoring plugin built into Apache APISIX for seamless integration with Datadog"
Review comment:
Hi @bisakhmondal @yzeng25, do we have a better description for it?
##########
File path: website/src/pages/plugins.js
##########
@@ -167,7 +167,7 @@ function Plugins(props) {
}
return (
<div key={plugin.name}>
- <PluginCard href={`https://apisix.apache.org/docs/apisix/plugins/${pluginUrl}`} target="_blank">
+ <PluginCard href={`https://apisix.apache.org/docs/apisix/next/plugins/${pluginUrl}`} target="_blank">
Review comment:
According to mailing list: https://lists.apache.org/thread/fprf95hxjwvbtomndsbd7mh9s7vzfykd
We don't have an agreement on this IMO 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #716: feat: add Datadog plugin card in plugin hub
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #716:
URL: https://github.com/apache/apisix-website/pull/716#issuecomment-966883922
wait #715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #716: feat: add Datadog plugin card in plugin hub
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #716:
URL: https://github.com/apache/apisix-website/pull/716#issuecomment-968199473
The datatog's plugin link is https://apisix.apache.org/docs/apisix/next/plugins/datadog
@1502shivam-singh Do you have any ideas on this? I'd prefer using this way:
1. Keep the https://apisix.apache.org/plugins/ page using the stable plugins link;
2. Adding a mark or note on Datadog, and saying this plugin is in the Next Version of Apache APISIX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #716: feat: add Datadog plugin card in plugin hub
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #716:
URL: https://github.com/apache/apisix-website/pull/716#issuecomment-969809441
I have added a beta tag to the plug-in card and added a comment on the hover, Also updated with links.
If there is still something that needs to be corrected, please help me to point it out. Thanks!
cc @1502shivam-singh @bzp2010 @bisakhmondal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org