You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/02 09:25:44 UTC
[GitHub] [ozone] xichen01 opened a new pull request, #3733: HDDS-7200 fixed inaccurate get request status code
xichen01 opened a new pull request, #3733:
URL: https://github.com/apache/ozone/pull/3733
## What changes were proposed in this pull request?
will get the content in a range( add such as: "Range: bytes=123-" at request header), The backend service needs to return this range of data, and the returned status code should be [206](https://www.rfc-editor.org/rfc/rfc7233#section-4.1)
current Ozone s3 getaway will return 200 instead of 206, this pr will be fixed it.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7200
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
Send a get request requesting range data, the return status should be 206.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on a diff in pull request #3733: HDDS-7200. Fixed inaccurate get request status code
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #3733:
URL: https://github.com/apache/ozone/pull/3733#discussion_r962137545
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -344,6 +344,8 @@ public Response get(
};
responseBuilder = Response
.ok(output)
Review Comment:
This line should be removed, as it equals to setting `status = OK` and `entity = output`.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xichen01 commented on a diff in pull request #3733: HDDS-7200. Fixed inaccurate get request status code
Posted by GitBox <gi...@apache.org>.
xichen01 commented on code in PR #3733:
URL: https://github.com/apache/ozone/pull/3733#discussion_r962323170
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -344,6 +344,8 @@ public Response get(
};
responseBuilder = Response
.ok(output)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xichen01 commented on pull request #3733: HDDS-7200. Fixed inaccurate get request status code
Posted by GitBox <gi...@apache.org>.
xichen01 commented on PR #3733:
URL: https://github.com/apache/ozone/pull/3733#issuecomment-1235536675
Run cat target/integration/summary.txt
org.apache.hadoop.ozone.scm.node.TestDecommissionAndMaintenance
org.apache.hadoop.ozone.scm.node.TestDecommissionAndMaintenance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen merged pull request #3733: HDDS-7200. Fixed inaccurate get request status code
Posted by GitBox <gi...@apache.org>.
kaijchen merged PR #3733:
URL: https://github.com/apache/ozone/pull/3733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org