You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org> on 2011/07/21 21:04:58 UTC
[jira] [Created] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Fix UDAFPercentile to tolerate null percentiles
-----------------------------------------------
Key: HIVE-2298
URL: https://issues.apache.org/jira/browse/HIVE-2298
Project: Hive
Issue Type: Bug
Reporter: Vaibhav Aggarwal
Assignee: Vaibhav Aggarwal
Attachments: HIVE-2298.patch
UDAFPercentile when passed null percentile list will throw a null pointer exception.
Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076040#comment-13076040 ]
Amareshwari Sriramadasu commented on HIVE-2298:
-----------------------------------------------
+1. Will commit once tests pass.
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HIVE-2298:
------------------------------------------
Status: Open (was: Patch Available)
The modified test udf_percentile.q fails with the patch. Can you look into?
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Aggarwal updated HIVE-2298:
-----------------------------------
Attachment: HIVE-2298-3.patch
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298-3.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2298:
---------------------------------
Status: Open (was: Patch Available)
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Aggarwal updated HIVE-2298:
-----------------------------------
Attachment: HIVE-2298-2.patch
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2298:
---------------------------------
Component/s: UDF
Affects Version/s: 0.7.0
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Aggarwal updated HIVE-2298:
-----------------------------------
Attachment: HIVE-2298.patch
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HIVE-2298:
------------------------------------------
Status: Open (was: Patch Available)
Can you include the test case also in the patch?
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2259-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Aggarwal updated HIVE-2298:
-----------------------------------
Status: Patch Available (was: Open)
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070814#comment-13070814 ]
Vaibhav Aggarwal commented on HIVE-2298:
----------------------------------------
I will make the style changes and try to add a test case to test this specific case.
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13075989#comment-13075989 ]
Vaibhav Aggarwal commented on HIVE-2298:
----------------------------------------
Also added a test case.
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079128#comment-13079128 ]
Vaibhav Aggarwal commented on HIVE-2298:
----------------------------------------
Hi Amreshwari
Thanks for reporting the diff.
I generated a new patch.
Hopefully this fixes the issue.
Vaibhav
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298-3.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070807#comment-13070807 ]
jiraposter@reviews.apache.org commented on HIVE-2298:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1189/#review1181
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java
<https://reviews.apache.org/r/1189/#comment2483>
Please fix the following checkstyle violations:
Line 238: File contains tab characters (this is the first instance).
Line 240: is longer than 100 characters.
Line 245: '}' should be on the same line.
- Carl
On 2011-07-25 21:53:12, Carl Steinbach wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1189/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-25 21:53:12)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Review request for HIVE-2298.
bq.
bq.
bq. This addresses bug HIVE-2298.
bq. https://issues.apache.org/jira/browse/HIVE-2298
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java 92db544
bq.
bq. Diff: https://reviews.apache.org/r/1189/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Carl
bq.
bq.
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080311#comment-13080311 ]
Hudson commented on HIVE-2298:
------------------------------
Integrated in Hive-trunk-h0.21 #876 (See [https://builds.apache.org/job/Hive-trunk-h0.21/876/])
HIVE-2298. Fix UDAFPercentile to tolerate null percentiles. Vaibhav Aggarwal via amareshwari
amareshwari : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154089
Files :
* /hive/trunk/ql/src/test/queries/clientpositive/udf_percentile.q
* /hive/trunk/ql/src/test/results/clientpositive/udf_percentile.q.out
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Fix For: 0.8.0
>
> Attachments: HIVE-2298-2.patch, HIVE-2298-3.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078490#comment-13078490 ]
Vaibhav Aggarwal commented on HIVE-2298:
----------------------------------------
Amreshwari, could you please post the diff or failure cause.
The test succeeded on my desktop.
I ran the following command:
ant test -Dtestcase=TestCliDriver -Dqfile=udf_percentile.q
Is there a different command I should be using to run just this particular test?
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078589#comment-13078589 ]
Amareshwari Sriramadasu commented on HIVE-2298:
-----------------------------------------------
Yes. It is the right command. Here is the failure:
{noformat}
[junit] Running org.apache.hadoop.hive.cli.TestCliDriver
[junit] Begin query: udf_percentile.q
[junit] junit.framework.AssertionFailedError: Client execution results failed with error code = 1
[junit] See build/ql/tmp/hive.log, or try "ant test ... -Dtest.silent=false" to get more logs.
[junit] at junit.framework.Assert.fail(Assert.java:47)
[junit] at org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_percentile(TestCliDriver.java:129)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[junit] at java.lang.reflect.Method.invoke(Method.java:597)
[junit] at junit.framework.TestCase.runTest(TestCase.java:154)
[junit] at junit.framework.TestCase.runBare(TestCase.java:127)
[junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
[junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at junit.framework.TestResult.run(TestResult.java:109)
[junit] at junit.framework.TestCase.run(TestCase.java:118)
[junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
[junit] at junit.framework.TestSuite.run(TestSuite.java:203)
[junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:422)
[junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931)
[junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785)
[junit] diff -a -I file: -I pfile: -I hdfs: -I /tmp/ -I invalidscheme: -I lastUpdateTime -I lastAccessTime -I [Oo]wner -I CreateTime -I LastAccessTime -I Location -I LOCATION ' -I transient_lastDdlTime -I last_modified_ -I java.lang.RuntimeException -I at org -I at sun -I at java -I at junit -I Caused by: -I LOCK_QUERYID: -I grantTime -I [.][.][.] [0-9]* more -I USING 'java -cp /home/amarsri/workspace/hive/build/ql/test/logs/clientpositive/udf_percentile.q.out /home/amarsri/workspace/hive/ql/src/test/results/clientpositive/udf_percentile.q.out
[junit] 0a1
[junit] > Preprocessor null
[junit] Exception: Client execution results failed with error code = 1
{noformat}
The fix would be as simple as regenerating the output. Can you look into?
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Aggarwal updated HIVE-2298:
-----------------------------------
Status: Patch Available (was: Open)
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Aggarwal updated HIVE-2298:
-----------------------------------
Status: Patch Available (was: Open)
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298-3.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070803#comment-13070803 ]
jiraposter@reviews.apache.org commented on HIVE-2298:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1189/
-----------------------------------------------------------
Review request for hive.
Summary
-------
Review request for HIVE-2298.
This addresses bug HIVE-2298.
https://issues.apache.org/jira/browse/HIVE-2298
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java 92db544
Diff: https://reviews.apache.org/r/1189/diff
Testing
-------
Thanks,
Carl
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Aggarwal updated HIVE-2298:
-----------------------------------
Attachment: HIVE-2259-2.patch
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2259-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HIVE-2298:
------------------------------------------
Resolution: Fixed
Fix Version/s: 0.8.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Vaibhav !
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Fix For: 0.8.0
>
> Attachments: HIVE-2298-2.patch, HIVE-2298-3.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Aggarwal updated HIVE-2298:
-----------------------------------
Attachment: (was: HIVE-2259-2.patch)
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Aggarwal updated HIVE-2298:
-----------------------------------
Status: Patch Available (was: Open)
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2259-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "Vaibhav Aggarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072621#comment-13072621 ]
Vaibhav Aggarwal commented on HIVE-2298:
----------------------------------------
HIVE 2298 patch was committed along with HIVE-2256 as one commit.
I created a new patch with the formatting fix.
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2259-2.patch, HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2298) Fix UDAFPercentile to tolerate null
percentiles
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070809#comment-13070809 ]
John Sichi commented on HIVE-2298:
----------------------------------
Is it possible to come up with a test case for this one?
> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
> Key: HIVE-2298
> URL: https://issues.apache.org/jira/browse/HIVE-2298
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 0.7.0
> Reporter: Vaibhav Aggarwal
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer exception.
> Submitting a small fix for that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira