You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Oliver Lietz (JIRA)" <ji...@apache.org> on 2013/01/24 19:23:13 UTC
[jira] [Comment Edited] (SLING-2714) Wrap LOGGER.debug calls in
ResourceProviderEntry
[ https://issues.apache.org/jira/browse/SLING-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561814#comment-13561814 ]
Oliver Lietz edited comment on SLING-2714 at 1/24/13 6:21 PM:
--------------------------------------------------------------
Wrapping is not really needed, is it? Just removing Arrays.toString() should do it.
"Array type arguments, including multi-dimensional arrays, are also supported."
http://slf4j.org/faq.html#logging_performance
And "private final Logger" instead of "private static Logger".
was (Author: olli):
Wrapping is not really needed, is it? Just removing Arrays.toString() should do it.
"Array type arguments, including multi-dimensional arrays, are also supported."
http://slf4j.org/faq.html#logging_performance
> Wrap LOGGER.debug calls in ResourceProviderEntry
> ------------------------------------------------
>
> Key: SLING-2714
> URL: https://issues.apache.org/jira/browse/SLING-2714
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
> Affects Versions: Resource Resolver 1.0.2
> Reporter: Alexander Muthmann
> Assignee: Carsten Ziegeler
> Fix For: Resource Resolver 1.0.4
>
> Attachments: SLING-2714.diff
>
>
> In ResourceProviderEntry.java there are multiple LOGGER.debug calls which access Arrays.toString(). This causes the Arrays.toString() call to be executed no matter which Logger-Level is set.
> Those calls should be wrapped in a LOGGER.isDebugEnabled().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira