You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/21 10:34:20 UTC
[GitHub] [ignite] ivandasch opened a new pull request #9508: IGNITE-15799 Fixes .NET release and nightly builds.
ivandasch opened a new pull request #9508:
URL: https://github.com/apache/ignite/pull/9508
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a change in pull request #9508: IGNITE-15779 .NET: Fix release and nightly builds
Posted by GitBox <gi...@apache.org>.
ivandasch commented on a change in pull request #9508:
URL: https://github.com/apache/ignite/pull/9508#discussion_r734738688
##########
File path: pom.xml
##########
@@ -653,11 +653,27 @@
project.setProperty(dest, project.getProperty(source).replace("-SNAPSHOT",
""));
}
+
+ // When running nightly build, 'new.client.version' can be incompatible
+ // with .NET AssemblyInformationalVersion requirements
+ // (i.e. 2.x.x.29394859 instead of 2.x.x).
+ // This function cuts excessive part of version.
+ function setCutClientVersion(dest, source) {
+ var value = project.getProperty(source);
+ var digitVer = /\d+\.\d+\.\d+/.exec(value);
Review comment:
It is not possible, unfortunately. AssemblyVersion must contain at most 4 positive numbers, less than max uint16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #9508: IGNITE-15779 Fixes .NET release and nightly builds.
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #9508:
URL: https://github.com/apache/ignite/pull/9508#discussion_r734647682
##########
File path: pom.xml
##########
@@ -653,11 +653,27 @@
project.setProperty(dest, project.getProperty(source).replace("-SNAPSHOT",
""));
}
+
+ // When running nightly build, 'new.client.version' can be incompatible
+ // with .NET AssemblyInformationalVersion requirements
+ // (i.e. 2.x.x.29394859 instead of 2.x.x).
+ // This function cuts excessive part of version.
+ function setCutClientVersion(dest, source) {
+ var value = project.getProperty(source);
+ var digitVer = /\d+\.\d+\.\d+/.exec(value);
Review comment:
I'm not sure it is correct to throw away a part of the version like this. Especially for nightly builds, we should pack a pre-release version, not a release one. Pre-release version is any version with a suffix like `-nightly`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a change in pull request #9508: IGNITE-15779 .NET: Fix release and nightly builds
Posted by GitBox <gi...@apache.org>.
ivandasch commented on a change in pull request #9508:
URL: https://github.com/apache/ignite/pull/9508#discussion_r734738688
##########
File path: pom.xml
##########
@@ -653,11 +653,27 @@
project.setProperty(dest, project.getProperty(source).replace("-SNAPSHOT",
""));
}
+
+ // When running nightly build, 'new.client.version' can be incompatible
+ // with .NET AssemblyInformationalVersion requirements
+ // (i.e. 2.x.x.29394859 instead of 2.x.x).
+ // This function cuts excessive part of version.
+ function setCutClientVersion(dest, source) {
+ var value = project.getProperty(source);
+ var digitVer = /\d+\.\d+\.\d+/.exec(value);
Review comment:
It is not possible, unfortunately. AssemblyVersion must contain at most 4 positive numbers, less than max uint16.
This regex just throw away current date, but it is preserved in zip archive of nugets. AFAIK nugets are published to some private repo (myget), so is it the real problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org