[GitHub] [kafka] jsancio commented on pull request #12885: KAFKA-14358; Disallow creation of cluster metadata partition

[GitBox <gi...@apache.org>]

jsancio commented on PR #12885:
URL: https://github.com/apache/kafka/pull/12885#issuecomment-1331311469

   > Thanks for the patch @jsancio. Just a couple of comments.
   > 
   > I tried creating `__cluster_metadata` on trunk and got a non-fatal error:
   > 
   > ```
   > [2022-11-29 13:11:47,725] ERROR Encountered metadata application fault: Error applying topics delta in MetadataDelta up to 116 (org.apache.kafka.server.fault.LoggingFaultHandler)
   > org.apache.kafka.common.errors.InconsistentTopicIdException: Tried to assign topic ID Some(wlfZq-nVSIashndGhJaHgA) to log for topic partition __cluster_metadata-0,but log already contained topic ID AAAAAAAAAAAAAAAAAAAAAQ
   > ```
   > 
   > I was able to create a different topic after this error, and the broker/controller seemed to restart fine (though the error happens again during replay). It _seems_ like a user creating this topic is not disastrous, but we should certainly avoid it :)
   > 
   > Edit: Apparently the topic does appear in the topic describe output, but produce and consume do not work.
   
   Yes. Before this change, if the user attempts to create this topic against a KRaft cluster the CreateTopics RPC will succeed but the replica manager wont find the log in the log manager.
   
   The behavior under the ZK implementation is also unexpected. The topic creation will succeed and the user will be able to produce and consume from it but if the brokers restart then the user will not able to produce and consume from it. This is because the code for loading log in the log manager is different from the code that creates logs in the log manager.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org