You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/26 09:26:09 UTC
[GitHub] [spark] mukever opened a new pull request, #37673: Modify the option configuration on separators of csv in the document
mukever opened a new pull request, #37673:
URL: https://github.com/apache/spark/pull/37673
Signed-off-by: mukever <mu...@163.com>
### What changes were proposed in this pull request?
Modify the option configuration on separators of CSV in the document
### Why are the changes needed?
modify the information in here
<img width="924" alt="image" src="https://user-images.githubusercontent.com/16496719/186872474-616417df-cfd0-49d1-83e8-8bf1dbe5be03.png">
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
the docs modified do not need to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37673: Modify the option configuration on separators of csv in the document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37673:
URL: https://github.com/apache/spark/pull/37673#issuecomment-1229208006
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mukever closed pull request #37673: Modify the option configuration on separators of csv in the document
Posted by GitBox <gi...@apache.org>.
mukever closed pull request #37673: Modify the option configuration on separators of csv in the document
URL: https://github.com/apache/spark/pull/37673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #37673: Modify the option configuration on separators of csv in the document
Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #37673:
URL: https://github.com/apache/spark/pull/37673#discussion_r955983252
##########
docs/sql-data-sources-csv.md:
##########
@@ -55,7 +55,7 @@ Data source options of CSV can be set via:
<table class="table">
<tr><th><b>Property Name</b></th><th><b>Default</b></th><th><b>Meaning</b></th><th><b>Scope</b></th></tr>
<tr>
- <td><code>sep</code></td>
Review Comment:
It seems `sep` is also correct:
https://github.com/apache/spark/blob/31ab8bc4d5df0c84cb5542200b286defea037cc2/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala#L101-L102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org