You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by stanlyxiang <gi...@git.apache.org> on 2017/02/23 08:17:03 UTC
[GitHub] incubator-hawq pull request #1143: HAWQ-1350. Add --enable-rps option to bui...
GitHub user stanlyxiang opened a pull request:
https://github.com/apache/incubator-hawq/pull/1143
HAWQ-1350. Add --enable-rps option to build ranger-plugin when build \u2026
\u2026hawq.
please help to review, thanks. @ictmalili @linwen @zhangh43 @interma @wcl14
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyxiang/incubator-hawq HAWQ-1350
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1143
----
commit de3f6daed42ab54ddd1413951e4ccc2ef7aaa52a
Author: stanlyxiang <st...@gmail.com>
Date: 2017-02-23T08:08:30Z
HAWQ-1350. Add --enable-rps option to build ranger-plugin when build hawq.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1143: HAWQ-1350. Add --enable-rps option to build rang...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1143
Merged into master. Close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1143: HAWQ-1350. Add --enable-rps option to bui...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1143#discussion_r102678227
--- Diff: config/tomcat.m4 ---
@@ -0,0 +1,59 @@
+dnl
+dnl tomcat.m4: Locates the Apache Tomcat/6.0.x and its scripts and jars.
+dnl
+
+# PGAC_CATALINA_HOME
+# ------------------
+AC_DEFUN([PGAC_CATALINA_HOME],
+[
+ AC_MSG_CHECKING([CATALINA_HOME])
+
+ dnl Use $CATALINA_HOME if specifed, otherwise look for java in the likely places.
+ dnl /usr/local/Cellar/tomcat@6/6.0.45/libexec
+ dnl /usr/lib/bigtop-tomcat
+ if test -x "${CATALINA_HOME}/bin/catalina.sh"; then
+ TOMCAT="${CATALINA_HOME}"
+ elif test -x "/usr/local/Cellar/tomcat@6/6.0.45/libexec/bin/catalina.sh"; then
--- End diff --
Oh. No, the version should be 6.0.x. I will remove this else option since I just found it's too specific to the path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1143: HAWQ-1350. Add --enable-rps option to bui...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1143#discussion_r102667786
--- Diff: config/tomcat.m4 ---
@@ -0,0 +1,59 @@
+dnl
+dnl tomcat.m4: Locates the Apache Tomcat/6.0.x and its scripts and jars.
+dnl
+
+# PGAC_CATALINA_HOME
+# ------------------
+AC_DEFUN([PGAC_CATALINA_HOME],
+[
+ AC_MSG_CHECKING([CATALINA_HOME])
+
+ dnl Use $CATALINA_HOME if specifed, otherwise look for java in the likely places.
+ dnl /usr/local/Cellar/tomcat@6/6.0.45/libexec
+ dnl /usr/lib/bigtop-tomcat
+ if test -x "${CATALINA_HOME}/bin/catalina.sh"; then
+ TOMCAT="${CATALINA_HOME}"
+ elif test -x "/usr/local/Cellar/tomcat@6/6.0.45/libexec/bin/catalina.sh"; then
--- End diff --
Are we bound to this tomcat version: 6.0.45?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1143: HAWQ-1350. Add --enable-rps option to build rang...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1143
I have a question: Is this for Ranger support only? If yes, should not enable-ranger be enough or better?
By the way, Shouldn't contrib/ranger-plugin be a better place for ranger-plugin?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1143: HAWQ-1350. Add --enable-rps option to bui...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1143: HAWQ-1350. Add --enable-rps option to build rang...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1143
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1143: HAWQ-1350. Add --enable-rps option to build rang...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1143
Yes. This is for ranger support only. In our work, we avoid to confuse users with ranger and ranger-plugin. Because users should install ranger (apache ranger) before use HAWQ integration with Ranger. We should avoid the misleading that ranger has been installed&enabled if users configure hawq with option "enable-ranger".
For the plugin folder, agree with you as Postgresql says "contrib directory include porting tools, analysis utilities, and plug-in features that are not part of the core PostgreSQL system". This part was committed by @denalex , we could discuss and file a jira to move if we reach a consensus.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---