[activemq-artemis] 01/04: add some TODOs for area cleanup still needed

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

robbie pushed a commit to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git

commit f648440c46fb5df7dde93c5c3c69ab27b7b2f230
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Fri Jul 29 12:51:00 2022 +0100

    add some TODOs for area cleanup still needed
---
 .../src/main/java/org/apache/activemq/artemis/boot/Artemis.java         | 1 +
 .../main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java   | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/artemis-boot/src/main/java/org/apache/activemq/artemis/boot/Artemis.java b/artemis-boot/src/main/java/org/apache/activemq/artemis/boot/Artemis.java
index db1b40dd00..6b436506d9 100644
--- a/artemis-boot/src/main/java/org/apache/activemq/artemis/boot/Artemis.java
+++ b/artemis-boot/src/main/java/org/apache/activemq/artemis/boot/Artemis.java
@@ -116,6 +116,7 @@ public class Artemis {
          System.setProperty("java.io.tmpdir", new File(fileInstance, "tmp").getCanonicalPath());
       }
 
+      //TODO: Remove or update? We arent using this prop anymore.
       // Lets try to covert the logging.configuration setting to a valid URI
       String loggingConfig = System.getProperty("logging.configuration");
       if (loggingConfig != null) {
diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java
index 87548fc150..b51ab02318 100644
--- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java
+++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java
@@ -212,6 +212,7 @@ public class SpawnedVMSupport {
          }
       }
 
+      // TODO: look into the usage of these (BEGINNING >)
       // The logs will be huge if you don't set this
       if (useLogging) {
          commandList.add("-Djava.util.logging.manager=org.jboss.logmanager.LogManager");
@@ -236,6 +237,7 @@ public class SpawnedVMSupport {
       if (loggingPlugin != null) {
          commandList.add("-Dorg.jboss.logging.Logger.pluginClass=" + loggingPlugin + " ");
       }
+      // TODO: look into these (< END)
 
       commandList.add(className);
       for (String arg : args) {