You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Brian Femiano (JIRA)" <ji...@apache.org> on 2012/10/13 04:21:03 UTC

[jira] [Created] (GIRAPH-368) HBaseVertexInput/Output formats handle setConf() internally

Brian Femiano created GIRAPH-368:
------------------------------------

             Summary: HBaseVertexInput/Output formats handle setConf() internally
                 Key: GIRAPH-368
                 URL: https://issues.apache.org/jira/browse/GIRAPH-368
             Project: Giraph
          Issue Type: Bug
            Reporter: Brian Femiano


My earlier patch GIRAPH-350 added more responsibility with the client and did not address the problem in split master/worker mode. My tests unfortunately do not cover pseudo/fully distributed scenarios. I noticed this condition in one of my HBase jobs and fixed it. 

Internally the HBaseVertexInput/Output formats now setConf() when appropriate, instead of forcing users to remember to call the static setConf() on the abstract class. 

In a separate ticket I will test the Accumulo I/O to see if it suffers from similar limitations.

This patch fixes the HBase I/O formats. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-368) HBaseVertexInput/Output formats handle setConf() internally

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475798#comment-13475798 ] 

Hudson commented on GIRAPH-368:
-------------------------------

Integrated in Giraph-trunk-Commit #240 (See [https://builds.apache.org/job/Giraph-trunk-Commit/240/])
    GIRAPH-368: HBaseVertexInput/Output formats handle setConf() internally (bfem via ereisman) (Revision 1398033)

     Result = SUCCESS
ereisman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398033
Files : 
* /giraph/trunk/CHANGELOG
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hbase/HBaseVertexInputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hbase/HBaseVertexOutputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hbase/TestHBaseRootMarkerVertextFormat.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeInputFormat.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeOutputFormat.java

                
> HBaseVertexInput/Output formats handle setConf() internally
> -----------------------------------------------------------
>
>                 Key: GIRAPH-368
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-368
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Brian Femiano
>            Assignee: Brian Femiano
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-368.patch
>
>
> My earlier patch GIRAPH-350 added more responsibility with the client and did not address the problem in split master/worker mode. My tests unfortunately do not cover pseudo/fully distributed scenarios. I noticed this condition in one of my HBase jobs and fixed it. 
> Internally the HBaseVertexInput/Output formats now setConf() when appropriate, instead of forcing users to remember to call the static setConf() on the abstract class. 
> In a separate ticket I will test the Accumulo I/O to see if it suffers from similar limitations.
> This patch fixes the HBase I/O formats. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-368) HBaseVertexInput/Output formats handle setConf() internally

Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Femiano updated GIRAPH-368:
---------------------------------

    Attachment: GIRAPH-368.patch
    
> HBaseVertexInput/Output formats handle setConf() internally
> -----------------------------------------------------------
>
>                 Key: GIRAPH-368
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-368
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Brian Femiano
>            Assignee: Brian Femiano
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-368.patch
>
>
> My earlier patch GIRAPH-350 added more responsibility with the client and did not address the problem in split master/worker mode. My tests unfortunately do not cover pseudo/fully distributed scenarios. I noticed this condition in one of my HBase jobs and fixed it. 
> Internally the HBaseVertexInput/Output formats now setConf() when appropriate, instead of forcing users to remember to call the static setConf() on the abstract class. 
> In a separate ticket I will test the Accumulo I/O to see if it suffers from similar limitations.
> This patch fixes the HBase I/O formats. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-368) HBaseVertexInput/Output formats handle setConf() internally

Posted by "Brian Femiano (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475505#comment-13475505 ] 

Brian Femiano commented on GIRAPH-368:
--------------------------------------

https://reviews.apache.org/r/7579/


                
> HBaseVertexInput/Output formats handle setConf() internally
> -----------------------------------------------------------
>
>                 Key: GIRAPH-368
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-368
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Brian Femiano
>            Assignee: Brian Femiano
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-368.patch
>
>
> My earlier patch GIRAPH-350 added more responsibility with the client and did not address the problem in split master/worker mode. My tests unfortunately do not cover pseudo/fully distributed scenarios. I noticed this condition in one of my HBase jobs and fixed it. 
> Internally the HBaseVertexInput/Output formats now setConf() when appropriate, instead of forcing users to remember to call the static setConf() on the abstract class. 
> In a separate ticket I will test the Accumulo I/O to see if it suffers from similar limitations.
> This patch fixes the HBase I/O formats. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira