[GitHub] [maven-resolver] cstamas commented on a diff in pull request #228: [MRESOLVER-305] Handle blocked state at connector level

[GitBox <gi...@apache.org>]

cstamas commented on code in PR #228:
URL: https://github.com/apache/maven-resolver/pull/228#discussion_r1044588589


##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java:
##########
@@ -109,6 +109,20 @@ public RepositoryConnector newRepositoryConnector( RepositorySystemSession sessi
         throws NoRepositoryConnectorException
     {
         requireNonNull( repository, "remote repository cannot be null" );
+
+        if ( repository.isBlocked() )
+        {
+            if ( repository.getMirroredRepositories().isEmpty() )
+            {
+                throw new NoRepositoryConnectorException( repository, "Blocked repository: " + repository );

Review Comment:
   if you look from where this block was _removed_, it is in same try-catch where this method is invoked (and throws this exception). This basically prevents any "remote access" to blocked repositories.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org