You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/21 00:21:29 UTC

[GitHub] [superset] betodealmeida commented on pull request #12635: feat: add decorator to guard public APIs

betodealmeida commented on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764064463


   > I know hashing is fast for most cases, but I'm wondering whether we can move this to be an offline job in some way?
   > 
   > I.e. instead of a decorator, store the hash for all public APIs in a separate file and run the checks in CI.
   
   Good point... we could also just add unit tests that import the functions and compare their signature hashes to hard coded values, that might be a more efficient approach.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org