You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/08 03:17:57 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.
codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
> Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.23%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11101 +/- ##
==========================================
- Coverage 65.57% 60.34% -5.24%
==========================================
Files 828 392 -436
Lines 39162 24569 -14593
Branches 3694 0 -3694
==========================================
- Hits 25681 14825 -10856
+ Misses 13371 9744 -3627
+ Partials 110 0 -110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.34% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (ø)` | |
| [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9FcnJvck1lc3NhZ2UvRXJyb3JBbGVydC50c3g=) | | |
| [...-frontend/src/dashboard/util/isDashboardLoading.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvaXNEYXNoYm9hcmRMb2FkaW5nLmpz) | | |
| ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...e7cef06](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org