[GitHub] [incubator-seatunnel] hililiwei commented on a diff in pull request #2609: [Feature][connector] Standardize plugin name

[GitBox <gi...@apache.org>]

hililiwei commented on code in PR #2609:
URL: https://github.com/apache/incubator-seatunnel/pull/2609#discussion_r979920036


##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-file/src/main/java/org/apache/seatunnel/flink/file/sink/FileSink.java:
##########
@@ -161,6 +161,6 @@ public void close() throws Exception {
 
     @Override
     public String getPluginName() {
-        return "FileSink";
+        return "File";

Review Comment:
   Make it the same as the Spark plug-in name.



##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-file/src/main/java/org/apache/seatunnel/flink/file/source/FileSource.java:
##########
@@ -125,6 +143,6 @@ public void prepare(FlinkEnvironment env) {
 
     @Override
     public String getPluginName() {
-        return "FileSource";
+        return "File";

Review Comment:
   Make it the same as the Spark plug-in name.



##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-doris/src/main/java/org/apache/seatunnel/flink/doris/sink/Doris.java:
##########
@@ -101,7 +101,7 @@ public void prepare(FlinkEnvironment prepareEnv) {
 
     @Override
     public String getPluginName() {
-        return "DorisSink";
+        return "Doris";

Review Comment:
   Make it the same as the Spark plug-in name.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org