Update Mapreduce dependency of Java for deb package
---------------------------------------------------
Key: MAPREDUCE-2728
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2728
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: build
Affects Versions: 0.23.0
Environment: Java 6, Ubuntu
Reporter: Eric Yang
Assignee: Eric Yang
Fix For: 0.23.0
Java dependency for Debian package is specified as open JDK, but it should depends on Sun version of Java. This dependency can be implicitly defined by hadoop-common dependency. Hence, there is no need to explicitly defined in hadoop-mapreduce.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/MAPREDUCE-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated MAPREDUCE-2728:
---------------------------------
Status: Open (was: Patch Available)
Patch staled due to mavenization.
> Update Mapreduce dependency of Java for deb package
> ---------------------------------------------------
>
> Key: MAPREDUCE-2728
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2728
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.0
> Environment: Java 6, Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2728.patch
>
>
> Java dependency for Debian package is specified as open JDK, but it should depends on Sun version of Java. This dependency can be implicitly defined by hadoop-common dependency. Hence, there is no need to explicitly defined in hadoop-mapreduce.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/MAPREDUCE-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070883#comment-13070883 ]
Eric Yang commented on MAPREDUCE-2728:
--------------------------------------
Eli, thank you for point out the internal conflict in me, and I retracted my +1 on HADOOP-7459. I think it is better to express Java dependency than without.
> Update Mapreduce dependency of Java for deb package
> ---------------------------------------------------
>
> Key: MAPREDUCE-2728
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2728
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.0
> Environment: Java 6, Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2728.patch
>
>
> Java dependency for Debian package is specified as open JDK, but it should depends on Sun version of Java. This dependency can be implicitly defined by hadoop-common dependency. Hence, there is no need to explicitly defined in hadoop-mapreduce.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/MAPREDUCE-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070758#comment-13070758 ]
Eric Yang commented on MAPREDUCE-2728:
--------------------------------------
For power user, it seems trivial to install Java and configure it correctly. However, it maybe better to express our dependency for package management system to install Java for novice user. Hence, automated deployment system like yum, apt-get can download required dependency correctly. I am uncertain removing JDK dependency is a good idea. I agree that deb and rpm dependencies should setup to be the same. We should have a resolution to choose HADOOP-7483 or HADOOP-7459 before we proceed.
> Update Mapreduce dependency of Java for deb package
> ---------------------------------------------------
>
> Key: MAPREDUCE-2728
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2728
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.0
> Environment: Java 6, Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.23.0
>
>
> Java dependency for Debian package is specified as open JDK, but it should depends on Sun version of Java. This dependency can be implicitly defined by hadoop-common dependency. Hence, there is no need to explicitly defined in hadoop-mapreduce.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/MAPREDUCE-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated MAPREDUCE-2728:
---------------------------------
Attachment: MAPREDUCE-2728.patch
Remove open jdk dependency.
> Update Mapreduce dependency of Java for deb package
> ---------------------------------------------------
>
> Key: MAPREDUCE-2728
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2728
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.0
> Environment: Java 6, Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2728.patch
>
>
> Java dependency for Debian package is specified as open JDK, but it should depends on Sun version of Java. This dependency can be implicitly defined by hadoop-common dependency. Hence, there is no need to explicitly defined in hadoop-mapreduce.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/MAPREDUCE-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070750#comment-13070750 ]
Eli Collins commented on MAPREDUCE-2728:
----------------------------------------
Why not make the debs consistent with the rpms in this respect? Eg HADOOP-7459 should cover debs as well right?
> Update Mapreduce dependency of Java for deb package
> ---------------------------------------------------
>
> Key: MAPREDUCE-2728
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2728
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.0
> Environment: Java 6, Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.23.0
>
>
> Java dependency for Debian package is specified as open JDK, but it should depends on Sun version of Java. This dependency can be implicitly defined by hadoop-common dependency. Hence, there is no need to explicitly defined in hadoop-mapreduce.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/MAPREDUCE-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070901#comment-13070901 ]
Hadoop QA commented on MAPREDUCE-2728:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12487771/MAPREDUCE-2728.patch
against trunk revision 1150926.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
org.apache.hadoop.fs.TestFileSystem
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/503//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/503//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/503//console
This message is automatically generated.
> Update Mapreduce dependency of Java for deb package
> ---------------------------------------------------
>
> Key: MAPREDUCE-2728
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2728
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.0
> Environment: Java 6, Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2728.patch
>
>
> Java dependency for Debian package is specified as open JDK, but it should depends on Sun version of Java. This dependency can be implicitly defined by hadoop-common dependency. Hence, there is no need to explicitly defined in hadoop-mapreduce.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/MAPREDUCE-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070855#comment-13070855 ]
Eli Collins commented on MAPREDUCE-2728:
----------------------------------------
bq. I am uncertain removing JDK dependency is a good idea. I agree that deb and rpm dependencies should setup to be the same. We should have a resolution to choose HADOOP-7483 or HADOOP-7459 before we proceed.
Doesn't your +1 on HADOOP-7459 indicate you are in favor of removing the java dependency? There's no real difference between rpms and debs in this respect.
> Update Mapreduce dependency of Java for deb package
> ---------------------------------------------------
>
> Key: MAPREDUCE-2728
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2728
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.0
> Environment: Java 6, Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2728.patch
>
>
> Java dependency for Debian package is specified as open JDK, but it should depends on Sun version of Java. This dependency can be implicitly defined by hadoop-common dependency. Hence, there is no need to explicitly defined in hadoop-mapreduce.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[ https://issues.apache.org/jira/browse/MAPREDUCE-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated MAPREDUCE-2728:
---------------------------------
Status: Patch Available (was: Open)
> Update Mapreduce dependency of Java for deb package
> ---------------------------------------------------
>
> Key: MAPREDUCE-2728
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2728
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.0
> Environment: Java 6, Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2728.patch
>
>
> Java dependency for Debian package is specified as open JDK, but it should depends on Sun version of Java. This dependency can be implicitly defined by hadoop-common dependency. Hence, there is no need to explicitly defined in hadoop-mapreduce.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira