You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/13 19:02:54 UTC
[GitHub] [arrow] westonpace opened a new pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
westonpace opened a new pull request #11408:
URL: https://github.com/apache/arrow/pull/11408
The error appears to be due to an older version of mc. This PR adds a minimum version check to ensure that we are working with a recent version of mc. If we are not it will skip the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#issuecomment-970251611
Benchmark runs are scheduled for baseline = f1fcc4f2bfe5b115bda96fa547da4c0b4328685c and contender = 690e3644d837505728ee94da576522948711ce0e. 690e3644d837505728ee94da576522948711ce0e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9f29de2c955840e592303354d7548f45...50d51964713544f79bfddd59b3f91ee6/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/93b4939a4e104062852cb5e6de22e54e...9d749756e4514ef6bb5c73eb7bc1f884/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d42c24ade0024985871ffccc7e055793...830b032f5c8540e6a7dfe16481933e6e/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#issuecomment-942625102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#issuecomment-970251611
Benchmark runs are scheduled for baseline = f1fcc4f2bfe5b115bda96fa547da4c0b4328685c and contender = 690e3644d837505728ee94da576522948711ce0e. 690e3644d837505728ee94da576522948711ce0e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9f29de2c955840e592303354d7548f45...50d51964713544f79bfddd59b3f91ee6/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/93b4939a4e104062852cb5e6de22e54e...9d749756e4514ef6bb5c73eb7bc1f884/)
[Finished :arrow_down:0.18% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d42c24ade0024985871ffccc7e055793...830b032f5c8540e6a7dfe16481933e6e/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#issuecomment-968916325
@westonpace can you update this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#discussion_r731291823
##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -348,6 +349,23 @@ def _wait_for_minio_startup(mcdir, address, access_key, secret_key):
raise Exception("mc command could not connect to local minio")
+def _ensure_minio_component_version(component, minimum_year):
+ full_args = [component, '--version']
+ proc = subprocess.Popen(full_args, stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE, encoding='utf-8')
+ retval = proc.wait(10)
+ if (retval != 0):
Review comment:
```suggestion
if proc.wait(10) != 0:
```
##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -348,6 +349,23 @@ def _wait_for_minio_startup(mcdir, address, access_key, secret_key):
raise Exception("mc command could not connect to local minio")
+def _ensure_minio_component_version(component, minimum_year):
+ full_args = [component, '--version']
+ proc = subprocess.Popen(full_args, stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE, encoding='utf-8')
+ retval = proc.wait(10)
+ if (retval != 0):
Review comment:
Just a small style nit (or we could keep retval as a separate variable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#issuecomment-970251611
Benchmark runs are scheduled for baseline = f1fcc4f2bfe5b115bda96fa547da4c0b4328685c and contender = 690e3644d837505728ee94da576522948711ce0e. 690e3644d837505728ee94da576522948711ce0e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9f29de2c955840e592303354d7548f45...50d51964713544f79bfddd59b3f91ee6/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/93b4939a4e104062852cb5e6de22e54e...9d749756e4514ef6bb5c73eb7bc1f884/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d42c24ade0024985871ffccc7e055793...830b032f5c8540e6a7dfe16481933e6e/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#issuecomment-970251611
Benchmark runs are scheduled for baseline = f1fcc4f2bfe5b115bda96fa547da4c0b4328685c and contender = 690e3644d837505728ee94da576522948711ce0e. 690e3644d837505728ee94da576522948711ce0e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9f29de2c955840e592303354d7548f45...50d51964713544f79bfddd59b3f91ee6/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/93b4939a4e104062852cb5e6de22e54e...9d749756e4514ef6bb5c73eb7bc1f884/)
[Finished :arrow_down:0.18% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d42c24ade0024985871ffccc7e055793...830b032f5c8540e6a7dfe16481933e6e/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#issuecomment-970150032
@jorisvandenbossche Thanks for the ping. I have rebased and added David's suggestion. Will merge on green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11408:
URL: https://github.com/apache/arrow/pull/11408#issuecomment-942625245
https://issues.apache.org/jira/browse/ARROW-14238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #11408: ARROW-14238: [Python] "could not run mc" error in test_fs.py
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #11408:
URL: https://github.com/apache/arrow/pull/11408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org