You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Abhijit Meshram (JIRA)" <ji...@apache.org> on 2008/01/10 07:12:34 UTC
[jira] Created: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Re-Factor Facility permissions of Product component to follow new patterns.
----------------------------------------------------------------------------
Key: OFBIZ-1569
URL: https://issues.apache.org/jira/browse/OFBIZ-1569
Project: OFBiz
Issue Type: Improvement
Components: product
Reporter: Abhijit Meshram
Attachments: facility_security.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Posted by "Abhijit Meshram (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhijit Meshram updated OFBIZ-1569:
-----------------------------------
Attachment: facility_security.patch
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Attachments: facility_security.patch, facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558657#action_12558657 ]
Jacques Le Roux commented on OFBIZ-1569:
----------------------------------------
This has been fixed in revision 611833. I will refactor it a bit, later...
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: facility_security.patch, facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1569.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks Abhijit ,
Your patch is in trunk revision: 611309
There was somehting weird in the patch around <!-- Product Inventory Services --> but I was able to easily merge after an update
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: facility_security.patch, facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Posted by "Abhijit Meshram (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558918#action_12558918 ]
Abhijit Meshram commented on OFBIZ-1569:
----------------------------------------
Jacques,
Really this was my mistake to not read the comment of Jacopo before work on security. Thanks to clear me on this.
Thanks.
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: facility_security.patch, facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558768#action_12558768 ]
Jacques Le Roux commented on OFBIZ-1569:
----------------------------------------
Abhijit,
I think you asked for comments, here they are :
You should not have put this lines in the patch :
+ <service name="checkFacilityRelatedPermission" engine="simple"
+ location="org/ofbiz/product/inventory/InventoryServices.xml" invoke="checkFacilityRelatedPermission">
+ <description>Facility Permission Checking Logic</description>
+ <implements service="permissionInterface"/>
+ </service>
When Jacopo created this simple-method (checkFacilityRelatedPermission, r547934) he put this comment
<!-- a method to centralize facility security code, meant to be called in-line with
call-simple-method, and the checkAction and callingMethodName attributes should be in the method context -->
Hence you should not have called it but in-line, facilityGenericPermission should have been called in place.
In revision 611917 I definitevely supressed checkFacilityRelatedPermission as a service. It never should have been one.
Thanks for your work.
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: facility_security.patch, facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Posted by "Abhijit Meshram (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhijit Meshram updated OFBIZ-1569:
-----------------------------------
Attachment: facility_security.patch
Refactor the Facility permission to follow up new pattern. Please have a look at this patch and suggest if it needs any modification.
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Attachments: facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-1569:
--------------------------------------
Assignee: Jacques Le Roux
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Assignee: Jacques Le Roux
> Attachments: facility_security.patch, facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Posted by "Wickersheimer Jeremy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558548#action_12558548 ]
Wickersheimer Jeremy commented on OFBIZ-1569:
---------------------------------------------
This patch might have broken something:
I tried to created an order as Admin but in the final step (createOrder) i get the error:
Did not complete the order, the following occurred:The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service [createInventoryItem] threw an unexpected exception/errororg.ofbiz.service.ServiceAuthException: The following required parameter is missing: [OUT] [checkFacilityRelatedPermission.hasPermission] (The following required parameter is missing: [OUT] [checkFacilityRelatedPermission.hasPermission])
Here is the first error from the log:
2008-01-14 17:03:15,681 (http-0.0.0.0-8443-Processor2) [ ModelService.java:462:ERROR] [ModelService.validate] : {checkFacilityRelatedPermission} : (OUT) Required test error: org.ofbiz.service.ServiceValidationException: The following required parameter is missing: [OUT] [checkFacilityRelatedPermission.hasPermission]
2008-01-14 17:03:15,686 (http-0.0.0.0-8443-Processor2) [ ServiceDispatcher.java:467:ERROR]
---- exception report ----------------------------------------------------------
Outgoing result (in runSync : checkFacilityRelatedPermission) does not match expected requirements
Exception: org.ofbiz.service.ServiceValidationException
Message: The following required parameter is missing: [OUT] [checkFacilityRelatedPermission.hasPermission]
---- stack trace ---------------------------------------------------------------
...
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: facility_security.patch, facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1569) Re-Factor Facility permissions of
Product component to follow new patterns.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557869#action_12557869 ]
Jacques Le Roux commented on OFBIZ-1569:
----------------------------------------
Thanks Abhijit ,
This looks good to me (only reviewed not tested yet).
> Re-Factor Facility permissions of Product component to follow new patterns.
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1569
> URL: https://issues.apache.org/jira/browse/OFBIZ-1569
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Reporter: Abhijit Meshram
> Assignee: Jacques Le Roux
> Attachments: facility_security.patch, facility_security.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.