[jira] [Commented] (FTPSERVER-344) Allow configuration of FileObserver and StatisticsObserver

["Dave Roberts (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FTPSERVER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761993#comment-13761993 ] 

Dave Roberts commented on FTPSERVER-344:
----------------------------------------

Based upon the current Git master, I've created a new branch and pushed some changes to it, in order to address this problem.

The Observer interfaces have moved to ftplet.  The set and reset methods mentioned above have gone to FtpStatistics.

Anyone wanting to set some observers can do so by creating an Ftplet and getting hold of the FtpStatistics instance within the init method.

Seems neater all round.

I tried creating a pull request but for some reason it states that the branch is xx amount behind the master.  I'm still getting used to Git, so maybe something I did wrong.  Branch can be viewed directly at https://github.com/peodratash/mina-ftpserver/tree/observer

                
> Allow configuration of FileObserver and StatisticsObserver
> ----------------------------------------------------------
>
>                 Key: FTPSERVER-344
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-344
>             Project: FtpServer
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.0.3
>            Reporter: Dave Roberts
>             Fix For: 1.1.0
>
>         Attachments: ftpStatistics2.patch, ftpStatistics.patch
>
>
> Setting this Observers currently involves a lot of casting and use of "internal" classes and interfaces.
> These need to be exposed to the public interfaces.
> The simplest idea would seem to be to push the methods up to the FtpStatistics interface.  However, these are only exposed through the Ftplet which are runtime objects, so a better mechanism is required.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira