You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/18 17:10:29 UTC

[GitHub] [kafka] huangyiminghappy opened a new pull request #9304: KAFKA-10502:TimestampRoutermay occur threadlocal leak

huangyiminghappy opened a new pull request #9304:
URL: https://github.com/apache/kafka/pull/9304


   Threadlocal  may can not set null,because it may create a memory leak, you can see the link:
   https://stackoverflow.com/questions/12424838/threadlocal-remove,so I think weather can invoke thread local.remove instead 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9304: KAFKA-10502:TimestampRouter may occur threadlocal leak

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9304:
URL: https://github.com/apache/kafka/pull/9304#issuecomment-699731935


   Reading on the SO thread I think this fix makes sense. Merging to trunk now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] huangyiminghappy commented on pull request #9304: KAFKA-10502:TimestampRouter may occur threadlocal leak

Posted by GitBox <gi...@apache.org>.
huangyiminghappy commented on pull request #9304:
URL: https://github.com/apache/kafka/pull/9304#issuecomment-699862527


   > Reading on the SO thread I think this fix makes sense. Merging to trunk now.
   
   thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] huangyiminghappy commented on pull request #9304: KAFKA-10502:TimestampRouter may occur threadlocal leak

Posted by GitBox <gi...@apache.org>.
huangyiminghappy commented on pull request #9304:
URL: https://github.com/apache/kafka/pull/9304#issuecomment-695813133


   @hachikuji  would  you help to review this pr.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] huangyiminghappy commented on pull request #9304: KAFKA-10502:TimestampRouter may occur threadlocal leak

Posted by GitBox <gi...@apache.org>.
huangyiminghappy commented on pull request #9304:
URL: https://github.com/apache/kafka/pull/9304#issuecomment-695813133


   @hachikuji  would  you help to review this pr.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #9304: KAFKA-10502:TimestampRouter may occur threadlocal leak

Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #9304:
URL: https://github.com/apache/kafka/pull/9304


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org