[jira] [Commented] (AIRFLOW-4731) GCS hook broken by storage client 1.16

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855575#comment-16855575 ] 

ASF GitHub Bot commented on AIRFLOW-4731:
-----------------------------------------

chronitis commented on pull request #5368: [AIRFLOW-4731] Broken get_bucket kwarg in GCS hook
URL: https://github.com/apache/airflow/pull/5368
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following https://issues.apache.org/jira/browse/AIRFLOW-4731
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   google-storage-client 1.16 introduced a breaking change where the
   signature of client.get_bucket changed from (bucket_name) to
   (bucket_or_name). Calls with named arguments to this method now fail.
   This commit makes all calls positional to work around this.
   
   Upstream change at https://github.com/googleapis/google-cloud-python/pull/7856
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   Updated one test in test_gcs_hook
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> GCS hook broken by storage client 1.16
> --------------------------------------
>
>                 Key: AIRFLOW-4731
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4731
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp
>    Affects Versions: 1.10.3
>            Reporter: Gordon Ball
>            Priority: Major
>
> Upgrading google-cloud-storage to 1.16 (allowed by the current spec in setup.py, ~= 1.14) causes breakage.
> Upstream change [https://github.com/googleapis/google-cloud-python/pull/7856|https://github.com/googleapis/google-cloud-python/pull/7856/files] altered the argument name for `get_bucket(...)`, so existing calls which use `get_bucket(bucket_name=...)` now cause an error. Comments on that pull acknowledge that this shouldn't have been done in a minor version.
> The simple fix would be to pin `google-cloud-storage == 1.15`, but this is probably fairly easy to fix call sites for future compatibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)