You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2016/08/03 08:57:02 UTC

[GitHub] zeppelin pull request #1275: Small refactoring of Python interpreter

GitHub user bzz opened a pull request:

    https://github.com/apache/zeppelin/pull/1275

    Small refactoring of Python interpreter

    ### What is this PR for?
    Small refactoring of Python interpreter, that is what it is.
    
    ### What type of PR is it?
    Refactoring
    
    ### Todos
    * [x] refactor `help()`
    * [x] impl `maxResult` fetch from JVM
    
    ### How should this be tested?
    `cd python && mvn -Dpython.test.exclude='' test ` pass (given that `pip install pandasql` and `pip install py4j`)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bzz/incubator-zeppelin python/refactoring

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1275
    
----
commit e800fd7032e48de858ae6f7a8deb6de0652e6e85
Author: Alexander Bezzubov <bz...@apache.org>
Date:   2016-08-03T08:05:09Z

    Make Python fetch maxResults from JVM

commit 15a35c8f61e8dfe80015eaa8f5f3ff1696e4d70f
Author: Alexander Bezzubov <bz...@apache.org>
Date:   2016-08-03T08:07:54Z

    Make .help() method a single string literal

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1275: Small refactoring of Python interpreter

Posted by minahlee <gi...@git.apache.org>.

Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1275
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1275: Small refactoring of Python interpreter

Posted by bzz <gi...@git.apache.org>.

Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1275
  
    Thank you @minahlee for prompt review!
    
    CI fails on spark 1.6 profile, same as master, and #1263  handled under [ZEPPELIN-1286](https://issues.apache.org/jira/browse/ZEPPELIN-1286)
    
    Merging if there is no further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1275: Small refactoring of Python interpreter

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1275


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1275: Small refactoring of Python interpreter

Posted by bzz <gi...@git.apache.org>.

Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1275
  
    Ready to be merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---