You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/06/09 05:36:58 UTC
[GitHub] [dubbo-go] ray2011 commented on a diff in pull request #1926: Fix: fix revision calc
ray2011 commented on code in PR #1926:
URL: https://github.com/apache/dubbo-go/pull/1926#discussion_r893087621
##########
common/metadata_info.go:
##########
@@ -87,10 +87,10 @@ func (mi *MetadataInfo) CalAndGetRevision() string {
if len(mi.Services) == 0 {
return "0"
}
- candidates := make([]string, 8)
+ candidates := make([]string, 0, 8)
for _, s := range mi.Services {
- sk := s.ServiceKey
+ sk := s.URL.GetParam(constant.InterfaceKey, "")
Review Comment:
> 获取interfaceKey，变量名sk改一下吧
已修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org