You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/23 14:21:50 UTC
[GitHub] [beam] jrmccluskey opened a new issue, #24334: [Task]: Update RunInference Notebooks to use Custom Inference Functions
jrmccluskey opened a new issue, #24334:
URL: https://github.com/apache/beam/issues/24334
### What needs to happen?
Once Beam 2.44 is released, the RunInference example notebooks should be updated to take advantage of the custom inference function capabilities added in #22572
### Issue Priority
Priority: 2
### Issue Component
Component: run-inference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ziqi-ma commented on issue #24334: [Task]: Update RunInference Notebooks to use Custom Inference Functions
Posted by GitBox <gi...@apache.org>.
ziqi-ma commented on issue #24334:
URL: https://github.com/apache/beam/issues/24334#issuecomment-1365517062
Would it be better to just add one more notebook using Huggingface generate rather than modifying the existing examples (since the existing ones don't really require calling a non-default inference function)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on issue #24334: [Task]: Update RunInference Notebooks to use Custom Inference Functions
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #24334:
URL: https://github.com/apache/beam/issues/24334#issuecomment-1613302457
#27305 should address most of this, we still need to update https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/run_inference_pytorch_tensorflow_sklearn.ipynb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on issue #24334: [Task]: Update RunInference Notebooks to use Custom Inference Functions
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #24334:
URL: https://github.com/apache/beam/issues/24334#issuecomment-1621798536
Hey @smeet07 we shouldn't need to use a new model, we just need to get rid of `HuggingFaceStripBatchingWrapper` from https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/run_inference_pytorch_tensorflow_sklearn.ipynb and use a custom inference function instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on issue #24334: [Task]: Update RunInference Notebooks to use Custom Inference Functions
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #24334:
URL: https://github.com/apache/beam/issues/24334#issuecomment-1520531971
It depends on the model handler, but for PyTorchTensor its `make_tensor_model_fn` - https://github.com/apache/beam/blob/fbc7df425cd0cdd3e5e1dca05601f7b023dbed96/sdks/python/apache_beam/ml/inference/pytorch_inference.py#L154
Roughly they should all follow the `make_<something>_fn` pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] smeet07 commented on issue #24334: [Task]: Update RunInference Notebooks to use Custom Inference Functions
Posted by "smeet07 (via GitHub)" <gi...@apache.org>.
smeet07 commented on issue #24334:
URL: https://github.com/apache/beam/issues/24334#issuecomment-1519408066
@jrmccluskey @damccorm I would like to contribute to this issue , I have one question though. What is the name of the convenience function that was agreed upon in #24062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] smeet07 commented on issue #24334: [Task]: Update RunInference Notebooks to use Custom Inference Functions
Posted by "smeet07 (via GitHub)" <gi...@apache.org>.
smeet07 commented on issue #24334:
URL: https://github.com/apache/beam/issues/24334#issuecomment-1621811168
Alright
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] smeet07 commented on issue #24334: [Task]: Update RunInference Notebooks to use Custom Inference Functions
Posted by "smeet07 (via GitHub)" <gi...@apache.org>.
smeet07 commented on issue #24334:
URL: https://github.com/apache/beam/issues/24334#issuecomment-1617943305
@damccorm what model should I use for the example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org