[jira] [Commented] (LUCENE-10097) Replace TreeMap use by HashMap when unnecessary

["Robert Muir (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413275#comment-17413275 ] 

Robert Muir commented on LUCENE-10097:
--------------------------------------

Note: apart from ordering, in some cases this is done intentionally to save memory (e.g. per-segment maps that might have lots of fields comes to mind). but, IMO in such cases we should add a comment/explanation as to why TreeMap is being used.

> Replace TreeMap use by HashMap when unnecessary
> -----------------------------------------------
>
>                 Key: LUCENE-10097
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10097
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Bruno Roustant
>            Assignee: Bruno Roustant
>            Priority: Major
>
> There are a couple of places where TreeMap is used although it could easily be replaced by a HashMap with potentially a single sort. Sometimes it would bring perf improvement (e.g. when TreeMap.entrySet() is called), other times it's more for consistency to use a simpler HashMap if there is no strong need for a TreeMap.
> I saw other places where we have TODOs to see whether we can replace the TreeMap, but when it is more complex, I'll prefer to open separate Jira issues.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org