You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/10/16 20:53:51 UTC
[PR] Minor: Add tests for binary / utf8 coercion [arrow-datafusion]
alamb opened a new pull request, #7839:
URL: https://github.com/apache/arrow-datafusion/pull/7839
## Which issue does this PR close?
Related to
* https://github.com/apache/arrow-datafusion/issues/7345
* https://github.com/apache/arrow-datafusion/issues/7344
* https://github.com/apache/arrow-datafusion/issues/7343
* https://github.com/apache/arrow-datafusion/issues/7342
## Rationale for this change
While working on Clickbench results as part of the #6782 I hit https://github.com/apache/arrow-datafusion/issues/7342 and I didn't know how many other issues @JayjeetAtGithub hit that are still an issue.
## What changes are included in this PR?
Add tests for the above issues (and it turns out that https://github.com/apache/arrow-datafusion/issues/7343 is no longer an issue)
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
This is only tests
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: Add tests for binary / utf8 coercion [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7839:
URL: https://github.com/apache/arrow-datafusion/pull/7839#issuecomment-1766219967
Since this PR is only tests and I have another PR I want to build on this, merging now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: Add tests for binary / utf8 coercion [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #7839: Minor: Add tests for binary / utf8 coercion
URL: https://github.com/apache/arrow-datafusion/pull/7839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: Add tests for binary / utf8 coercion [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7839:
URL: https://github.com/apache/arrow-datafusion/pull/7839#issuecomment-1765304747
I found fixing the issues was straightforward, so let's just use the same PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: Add tests for binary / utf8 coercion [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7839:
URL: https://github.com/apache/arrow-datafusion/pull/7839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org