You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/06/01 18:36:53 UTC
[kudu-CR](branch-1.17.x) [util] clear OpenSSL error queue on jwt-cpp activity
Hello Zoltan Chovan, Attila Bukor, Wenzhe Zhou,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19984
to review the following change.
Change subject: [util] clear OpenSSL error queue on jwt-cpp activity
......................................................................
[util] clear OpenSSL error queue on jwt-cpp activity
As it turns out, jwt-cpp doesn't clean up OpenSSL error queue in case
of errors. While I think it's a good idea to correct that improper
OpenSSL API usage in the jwt-cpp library itself (and I'm going to work
on a patch for jwt-cpp library upstream), I updated Kudu's jwt-util
code to report on those errors and clean the error queue as an interim
solution.
I haven't added any tests, but a few tests in a follow-up patch would
fail without these changes.
This is a follow-up to 5a3d116f302bde07e86bf80c237f8a595d5003b4.
Change-Id: I1a18a0d78bca0ea32878dc3825523e1bd6ecb019
Reviewed-on: http://gerrit.cloudera.org:8080/19895
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit 1f00b0f42062629646d0e892436198893d89de36)
---
M python/kudu/tests/test_client.py
M src/kudu/util/jwt-util-test.cc
M src/kudu/util/jwt-util.cc
3 files changed, 47 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/19984/1
--
To view, visit http://gerrit.cloudera.org:8080/19984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a18a0d78bca0ea32878dc3825523e1bd6ecb019
Gerrit-Change-Number: 19984
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](branch-1.17.x) [util] clear OpenSSL error queue on jwt-cpp activity
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19984 )
Change subject: [util] clear OpenSSL error queue on jwt-cpp activity
......................................................................
[util] clear OpenSSL error queue on jwt-cpp activity
As it turns out, jwt-cpp doesn't clean up OpenSSL error queue in case
of errors. While I think it's a good idea to correct that improper
OpenSSL API usage in the jwt-cpp library itself (and I'm going to work
on a patch for jwt-cpp library upstream), I updated Kudu's jwt-util
code to report on those errors and clean the error queue as an interim
solution.
I haven't added any tests, but a few tests in a follow-up patch would
fail without these changes.
This is a follow-up to 5a3d116f302bde07e86bf80c237f8a595d5003b4.
Change-Id: I1a18a0d78bca0ea32878dc3825523e1bd6ecb019
Reviewed-on: http://gerrit.cloudera.org:8080/19895
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit 1f00b0f42062629646d0e892436198893d89de36)
Reviewed-on: http://gerrit.cloudera.org:8080/19984
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M python/kudu/tests/test_client.py
M src/kudu/util/jwt-util-test.cc
M src/kudu/util/jwt-util.cc
3 files changed, 47 insertions(+), 48 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a18a0d78bca0ea32878dc3825523e1bd6ecb019
Gerrit-Change-Number: 19984
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](branch-1.17.x) [util] clear OpenSSL error queue on jwt-cpp activity
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19984 )
Change subject: [util] clear OpenSSL error queue on jwt-cpp activity
......................................................................
Patch Set 1: Code-Review+2
This changelist is a dependency for https://gerrit.cloudera.org/#/c/19986/, where the latter is already given +2.
I assume that means this patch automatically gets +2 as well.
--
To view, visit http://gerrit.cloudera.org:8080/19984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a18a0d78bca0ea32878dc3825523e1bd6ecb019
Gerrit-Change-Number: 19984
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Jun 2023 19:14:17 +0000
Gerrit-HasComments: No