You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/02 11:56:04 UTC
[jira] [Commented] (CAMEL-11222) Spring Boot Mojo should use
formatter properties from JBoss Forge
[ https://issues.apache.org/jira/browse/CAMEL-11222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992769#comment-15992769 ]
ASF GitHub Bot commented on CAMEL-11222:
----------------------------------------
GitHub user zregvart opened a pull request:
https://github.com/apache/camel/pull/1670
CAMEL-11222 Spring Boot Mojo should use formatter properties from JBoss Forge
This changes the Spring Boot Mojo to use Formatter options instead of custom formatting. Which makes it easier to change formatting definition and performs the source code generation in one pass.
I've added new line at EOF formatter option which is why two commits one for Mojo change another for the auto-configuration regeneration.
Left for review and 2.20, after 2.19 release, thanks 👍
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zregvart/camel CAMEL-11222
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1670.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1670
----
commit 66f816f4168f968754a0292a7eb6ef7687a7ff58
Author: Zoran Regvart <zr...@apache.org>
Date: 2017-05-02T09:22:35Z
CAMEL-11222 Spring Boot Mojo should use formatt...
...er properties from JBoss Forge
This changes the Spring Boot Mojo to use Formatter options instead of
custom formatting. Which makes it easier to change formatting definition
and performs the source code generation in one pass.
commit 6dbc9cfa05a382e9c6d7180532c8250c950bedd0
Author: Zoran Regvart <zr...@apache.org>
Date: 2017-05-02T11:41:47Z
CAMEL-11222 Spring Boot Mojo should use formatt...
...er properties from JBoss Forge
Regenerates the Spring Boot Auto-configuration support, added a new line
at the EOF.
----
> Spring Boot Mojo should use formatter properties from JBoss Forge
> -----------------------------------------------------------------
>
> Key: CAMEL-11222
> URL: https://issues.apache.org/jira/browse/CAMEL-11222
> Project: Camel
> Issue Type: Improvement
> Components: tooling
> Affects Versions: 2.20.0
> Reporter: Zoran Regvart
> Assignee: Zoran Regvart
> Priority: Trivial
>
> The Maven Spring Boot Auto-configuration Mojo performs simple generated source formatting by hand, it should use the provided Formatter shaded in JBoss Forge. This will allow format customization and one-pass source code generation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)