You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/22 00:54:05 UTC

[GitHub] [pulsar-client-go] dferstay commented on pull request #669: [ClientOptions] Allow callers to specify custom metric name qualifiers

dferstay commented on pull request #669:
URL: https://github.com/apache/pulsar-client-go/pull/669#issuecomment-974966347


   @cckellogg , thanks for the review; I'm going to close this PR due to the deprecation of namespace and subsystem in the next version of the prometheus go client API.  If you think it is worthwhile exposing a custom metrics prefix string field in `ClientOptions` to achieve a similar effect let me know and I'll open a new PR.  Otherwise, users can lean on the existing custom metric labels to disambiguate metrics collected from different services using pulsar-client-go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org