You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/03 11:27:38 UTC
[GitHub] [hbase] binlijin opened a new pull request #982: HBASE-23636
Disable table may hang when regionserver stop or abort.
binlijin opened a new pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
binlijin commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363009645
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRaceBetweenSCPAndDTP.java
##########
@@ -0,0 +1,146 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.assignment;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.master.HMaster;
+import org.apache.hadoop.hbase.master.MasterServices;
+import org.apache.hadoop.hbase.master.RegionPlan;
+import org.apache.hadoop.hbase.master.procedure.DisableTableProcedure;
+import org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure;
+import org.apache.hadoop.hbase.procedure2.ProcedureExecutor;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.zookeeper.KeeperException;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.Future;
+
+/**
+ * Testcase for HBASE-23636.
+ */
+@Category({ MasterTests.class, LargeTests.class })
+public class TestRaceBetweenSCPAndDTP {
+ private static final Logger LOG = LoggerFactory.getLogger(TestRaceBetweenSCPAndDTP.class);
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363018205
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -482,13 +482,18 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
regionNode.getProcedure().serverCrashed(env, regionNode, getServerName());
continue;
}
- if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
- TableState.State.DISABLING, TableState.State.DISABLED)) {
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLING)) {
env.getAssignmentManager().regionClosedAbnormally(regionNode);
- LOG.info("{} found table disabled for region {}, set it state to ABNORMALLY_CLOSED.",
+ LOG.info("{} found table disabling for region {}, set it state to ABNORMALLY_CLOSED.",
this, regionNode);
continue;
}
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLED)) {
+ LOG.warn("{} found table disabled for region {}.", this, regionNode);
Review comment:
`this` would print `server`, `splitWal` and `meta` correct? or it will print `pid`, `ppid`, `state` etc additionally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on issue #982: HBASE-23636 Disable table
may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
binlijin commented on issue #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#issuecomment-571033889
@Apache9 @virajjasani Thanks for the reviewing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363018415
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -482,13 +482,18 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
regionNode.getProcedure().serverCrashed(env, regionNode, getServerName());
continue;
}
- if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
- TableState.State.DISABLING, TableState.State.DISABLED)) {
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLING)) {
env.getAssignmentManager().regionClosedAbnormally(regionNode);
- LOG.info("{} found table disabled for region {}, set it state to ABNORMALLY_CLOSED.",
+ LOG.info("{} found table disabling for region {}, set it state to ABNORMALLY_CLOSED.",
this, regionNode);
continue;
}
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLED)) {
+ LOG.warn("{} found table disabled for region {}.", this, regionNode);
Review comment:
Seems like it will print everything, is it good to log:
```
LOG.warn("Found table disabled for region {}, procDetails: {}", regionNode, this);
```
if you feel this might be more readable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #982: HBASE-23636 Disable
table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#issuecomment-570920846
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 56s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 37s | master passed |
| +1 :green_heart: | compile | 1m 19s | master passed |
| +1 :green_heart: | checkstyle | 1m 53s | master passed |
| +1 :green_heart: | shadedjars | 6m 31s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 50s | master passed |
| +0 :ok: | spotbugs | 6m 6s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 6m 3s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 52s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 30s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 34s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed |
| +1 :green_heart: | findbugs | 4m 57s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 156m 54s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
| | | 228m 1s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/982 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 09f5ab03e091 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-982/out/precommit/personality/provided.sh |
| git revision | master / ab9766599d |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/3/testReport/ |
| Max. process+thread count | 5342 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
binlijin commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363009646
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -484,6 +484,9 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
}
if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
TableState.State.DISABLING, TableState.State.DISABLED)) {
+ env.getAssignmentManager().regionClosedAbnormally(regionNode);
Review comment:
Looks like no need, let me fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #982: HBASE-23636 Disable
table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#issuecomment-570761100
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 59s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 1m 31s | master passed |
| +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
| +0 :ok: | spotbugs | 5m 6s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 5s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 37s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 28s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 23s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 59s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
| +1 :green_heart: | findbugs | 5m 15s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 184m 22s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. |
| | | 250m 9s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.regionserver.TestRegionReplicasWithRestartScenarios |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/982 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 7cf05c83e51d 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-982/out/precommit/personality/provided.sh |
| git revision | master / ab9766599d |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/2/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/2/testReport/ |
| Max. process+thread count | 5488 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363151004
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -482,8 +482,16 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
regionNode.getProcedure().serverCrashed(env, regionNode, getServerName());
continue;
}
- if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
- TableState.State.DISABLING, TableState.State.DISABLED)) {
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLING)) {
+ env.getAssignmentManager().regionClosedAbnormally(regionNode);
+ LOG.info("{} found table disabling for region {}, set it state to ABNORMALLY_CLOSED.",
+ this, regionNode);
+ continue;
+ }
+ if (env.getMasterServices().getTableStateManager()
Review comment:
And also here, described why we do not need to set the state. I think the state here should already be CLOSED? And I wonder whether we could reach here, since the region is sitll in OPEN or OPENING state but the server recorded in AM is already dead so we can not close it in TRSP...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #982: HBASE-23636 Disable
table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#issuecomment-571071302
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 45s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 57s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 1m 31s | master passed |
| +1 :green_heart: | shadedjars | 5m 3s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
| +0 :ok: | spotbugs | 4m 52s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 51s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 31s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 28s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 1s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 34s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed |
| +1 :green_heart: | findbugs | 4m 47s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 158m 35s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
| | | 224m 35s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/982 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux adb96e356770 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-982/out/precommit/personality/provided.sh |
| git revision | master / ab9766599d |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/4/testReport/ |
| Max. process+thread count | 5415 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/4/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r362799209
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -484,6 +484,9 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
}
if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
TableState.State.DISABLING, TableState.State.DISABLED)) {
+ env.getAssignmentManager().regionClosedAbnormally(regionNode);
Review comment:
Do we still need to set this if the TableState is DISABLED?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #982: HBASE-23636 Disable table
may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#issuecomment-570992637
Oh, I know. The problem here is that, if we just skip the region in SCP, the region will remaining in OPEN state so we will try to close it in DTP and it will never succeed...
Let me see the patch again...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363018415
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -482,13 +482,18 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
regionNode.getProcedure().serverCrashed(env, regionNode, getServerName());
continue;
}
- if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
- TableState.State.DISABLING, TableState.State.DISABLED)) {
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLING)) {
env.getAssignmentManager().regionClosedAbnormally(regionNode);
- LOG.info("{} found table disabled for region {}, set it state to ABNORMALLY_CLOSED.",
+ LOG.info("{} found table disabling for region {}, set it state to ABNORMALLY_CLOSED.",
this, regionNode);
continue;
}
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLED)) {
+ LOG.warn("{} found table disabled for region {}.", this, regionNode);
Review comment:
Seems like it will print everything, is it good to log:
```
LOG.warn("Found table disabled for region {}, procDetails: {}", regionNode, this);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #982: HBASE-23636 Disable
table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#issuecomment-570608207
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 48s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 7s | master passed |
| +1 :green_heart: | compile | 1m 10s | master passed |
| +1 :green_heart: | checkstyle | 1m 50s | master passed |
| +1 :green_heart: | shadedjars | 6m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 55s | master passed |
| +0 :ok: | spotbugs | 6m 27s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 6m 24s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 55s | the patch passed |
| +1 :green_heart: | compile | 1m 22s | the patch passed |
| +1 :green_heart: | javac | 1m 22s | the patch passed |
| -1 :x: | checkstyle | 1m 49s | hbase-server: The patch generated 4 new + 11 unchanged - 0 fixed = 15 total (was 11) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 6m 10s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 21m 47s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 42s | the patch passed |
| +1 :green_heart: | findbugs | 6m 9s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 164m 35s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 245m 17s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/982 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 4553cfcc868c 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-982/out/precommit/personality/provided.sh |
| git revision | master / 85ecdd10a9 |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/1/artifact/out/diff-checkstyle-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/1/testReport/ |
| Max. process+thread count | 5370 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-982/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin merged pull request #982: HBASE-23636 Disable
table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
binlijin merged pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #982: HBASE-23636 Disable table
may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#issuecomment-570991746
We have some special logics in DisableTableProcedure...
Let me take a look on why these logics do not work...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
binlijin commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363085761
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -482,13 +482,18 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
regionNode.getProcedure().serverCrashed(env, regionNode, getServerName());
continue;
}
- if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
- TableState.State.DISABLING, TableState.State.DISABLED)) {
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLING)) {
env.getAssignmentManager().regionClosedAbnormally(regionNode);
- LOG.info("{} found table disabled for region {}, set it state to ABNORMALLY_CLOSED.",
+ LOG.info("{} found table disabling for region {}, set it state to ABNORMALLY_CLOSED.",
this, regionNode);
continue;
}
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLED)) {
+ LOG.warn("{} found table disabled for region {}.", this, regionNode);
Review comment:
done, change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r362804109
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRaceBetweenSCPAndDTP.java
##########
@@ -0,0 +1,146 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.assignment;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.master.HMaster;
+import org.apache.hadoop.hbase.master.MasterServices;
+import org.apache.hadoop.hbase.master.RegionPlan;
+import org.apache.hadoop.hbase.master.procedure.DisableTableProcedure;
+import org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure;
+import org.apache.hadoop.hbase.procedure2.ProcedureExecutor;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.zookeeper.KeeperException;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.Future;
+
+/**
+ * Testcase for HBASE-23636.
+ */
+@Category({ MasterTests.class, LargeTests.class })
+public class TestRaceBetweenSCPAndDTP {
+ private static final Logger LOG = LoggerFactory.getLogger(TestRaceBetweenSCPAndDTP.class);
Review comment:
`LOG` is not being used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r362806126
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRaceBetweenSCPAndDTP.java
##########
@@ -0,0 +1,146 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.assignment;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.master.HMaster;
+import org.apache.hadoop.hbase.master.MasterServices;
+import org.apache.hadoop.hbase.master.RegionPlan;
+import org.apache.hadoop.hbase.master.procedure.DisableTableProcedure;
+import org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure;
+import org.apache.hadoop.hbase.procedure2.ProcedureExecutor;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.zookeeper.KeeperException;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.Future;
Review comment:
redundant import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
binlijin commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363166908
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -482,8 +482,16 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
regionNode.getProcedure().serverCrashed(env, regionNode, getServerName());
continue;
}
- if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
- TableState.State.DISABLING, TableState.State.DISABLED)) {
+ if (env.getMasterServices().getTableStateManager()
+ .isTableState(regionNode.getTable(), TableState.State.DISABLING)) {
+ env.getAssignmentManager().regionClosedAbnormally(regionNode);
+ LOG.info("{} found table disabling for region {}, set it state to ABNORMALLY_CLOSED.",
+ this, regionNode);
+ continue;
+ }
+ if (env.getMasterServices().getTableStateManager()
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
binlijin commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363166974
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -484,6 +484,9 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
}
if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
TableState.State.DISABLING, TableState.State.DISABLED)) {
+ env.getAssignmentManager().regionClosedAbnormally(regionNode);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363150448
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -484,6 +484,9 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
}
if (env.getMasterServices().getTableStateManager().isTableState(regionNode.getTable(),
TableState.State.DISABLING, TableState.State.DISABLED)) {
+ env.getAssignmentManager().regionClosedAbnormally(regionNode);
Review comment:
Please add some comments to describe the problem here? We need to change the state here otherwise the TRSP scheduled by DTP will try to close the region from a dead server and will never succeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #982:
HBASE-23636 Disable table may hang when regionserver stop or abort.
Posted by GitBox <gi...@apache.org>.
binlijin commented on a change in pull request #982: HBASE-23636 Disable table may hang when regionserver stop or abort.
URL: https://github.com/apache/hbase/pull/982#discussion_r363009642
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRaceBetweenSCPAndDTP.java
##########
@@ -0,0 +1,146 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.assignment;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.master.HMaster;
+import org.apache.hadoop.hbase.master.MasterServices;
+import org.apache.hadoop.hbase.master.RegionPlan;
+import org.apache.hadoop.hbase.master.procedure.DisableTableProcedure;
+import org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure;
+import org.apache.hadoop.hbase.procedure2.ProcedureExecutor;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.zookeeper.KeeperException;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.Future;
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services