[GitHub] [hadoop] 9uapaw commented on a change in pull request #3314: YARN-10891. Extend QueueInfo with max-parallel-apps in CS.

[GitBox <gi...@apache.org>]

9uapaw commented on a change in pull request #3314:
URL: https://github.com/apache/hadoop/pull/3314#discussion_r694737717



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
##########
@@ -135,7 +137,7 @@ private static void setupQueueConfiguration(
 
     // Define top-level queues
     config.setQueues(CapacitySchedulerConfiguration.ROOT,
-        new String[] {"a", "b"});
+        new String[] {"a", "b", "d"});

Review comment:
       This test is already convoluted as it is. If it is possible, setting max-parallel-apps on an existing queue would be better.

##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CSQueue.java
##########
@@ -151,6 +151,12 @@
    * @return current run-state
    */
   public QueueState getState();
+
+  /**
+   * Get the max-parallel-applications property of the queue
+   * @return max-parallel-applications
+   */
+  public int getMaxParallelApps();

Review comment:
       I am not familiar with the convention whether we are allowed to add new methods on CSQueue, as it is marked as Stable. Check weight, which has been added recently, but was not introduced in CSQueue either. 

##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
##########
@@ -147,6 +149,9 @@ private static void setupQueueConfiguration(
     final String C = CapacitySchedulerConfiguration.ROOT + ".c";
     config.setCapacity(C, "[memory=1024]");
 
+    final String D = CapacitySchedulerConfiguration.ROOT + ".d";
+    config.setInt(PREFIX + D + DOT + MAX_PARALLEL_APPLICATIONS, 50);

Review comment:
       This idiom is usable by invoking CSConfiguration#getQueuePrefix(queuePath)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org