You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Wood (Code Review)" <ge...@cloudera.org> on 2017/11/07 01:06:33 UTC
[Impala-ASF-CR] IMPALA-6155: Ensure TPC-DS result orders can't vary.
Tim Wood has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8484
Change subject: IMPALA-6155: Ensure TPC-DS result orders can't vary.
......................................................................
IMPALA-6155: Ensure TPC-DS result orders can't vary.
Add a 3rd-rank sort key (sales column) to ORDER BY list.
Testing:
- Passed local tests/run-tests.py ...
- Analyzed all non-Kudu TPC-DS query files that use ORDER BY for similar patterns, found no others.
Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
---
M testdata/workloads/tpcds/queries/tpcds-q77a.test
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/8484/2
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6155: Ensure TPC-DS result orders can't vary.
Posted by "Tim Wood (Code Review)" <ge...@cloudera.org>.
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 )
Change subject: IMPALA-6155: Ensure TPC-DS result orders can't vary.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8484/2/testdata/workloads/tpcds/queries/tpcds-q77a.test
File testdata/workloads/tpcds/queries/tpcds-q77a.test:
http://gerrit.cloudera.org:8080/#/c/8484/2/testdata/workloads/tpcds/queries/tpcds-q77a.test@120
PS2, Line 120: ---- RESULTS
> Another option is to use the VERIFY_IS_EQUAL_SORTED verifier instead of mod
I'm open to either approach. The fewer hands laid on the SQL, the better, probably. :) If no one weighs in against by Tues. COB, I'll change it.
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 02:51:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 )
Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1442/
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 20:55:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 )
Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
......................................................................
Patch Set 3: Code-Review+2
Thanks Tim W.
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 20:54:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Posted by "Tim Wood (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, Michael Brown, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8484
to look at the new patch set (#3).
Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
......................................................................
IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Use VERIFY_IS_EQUAL_SORTED tag on RESULTS section to allow low-order
sort deviations to compare.
Testing:
- Passed local tests/run-tests.py ...
- Changed order of expected rows by low-order column and verified test still passes.
- Analyzed all TPC-DS query files for similar patterns, found no others.
Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
---
M testdata/workloads/tpcds/queries/tpcds-q77a.test
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/8484/3
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 )
Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
......................................................................
Patch Set 3: Code-Review+1
I haven't dabbled enough with test files to know that VERIFY_IS_EQUAL_SORTED even exists. I agree with its use over changing the TPC-DS queries.
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 20:53:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Posted by "Tim Wood (Code Review)" <ge...@cloudera.org>.
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 )
Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
......................................................................
Patch Set 3:
> Uploaded patch set 3.
Applied Tim A.'s suggestion.
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 20:42:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6155: Ensure TPC-DS result orders can't vary.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 )
Change subject: IMPALA-6155: Ensure TPC-DS result orders can't vary.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8484/2/testdata/workloads/tpcds/queries/tpcds-q77a.test
File testdata/workloads/tpcds/queries/tpcds-q77a.test:
http://gerrit.cloudera.org:8080/#/c/8484/2/testdata/workloads/tpcds/queries/tpcds-q77a.test@120
PS2, Line 120: ---- RESULTS
Another option is to use the VERIFY_IS_EQUAL_SORTED verifier instead of modifying the query. That's not very strict but might be better than diverging the queries further from the official TPC-DS versions. I haven't been following that closely so not sure what the general approach has been with modifications vs changing the verification logic.
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 01:20:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8484 )
Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
......................................................................
IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Use VERIFY_IS_EQUAL_SORTED tag on RESULTS section to allow low-order
sort deviations to compare.
Testing:
- Passed local tests/run-tests.py ...
- Changed order of expected rows by low-order column and verified test still passes.
- Analyzed all TPC-DS query files for similar patterns, found no others.
Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Reviewed-on: http://gerrit.cloudera.org:8080/8484
Reviewed-by: Michael Brown <mi...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M testdata/workloads/tpcds/queries/tpcds-q77a.test
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Brown: Looks good to me, but someone else must approve
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 )
Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Nov 2017 00:13:54 +0000
Gerrit-HasComments: No